-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub CI and a few cleanups #45
base: main
Are you sure you want to change the base?
Conversation
I'm not sure if I want to have github ci present in this repo. That said, the other commits look good, can you squash them? |
I always find squashing to be a rather lossy deal because it breaks the connection between specific commit message and content, so I prefer not to. I'll remove the CI commit though, and see what I can squash without significant loss of information. I'm also a bit unsure about the last two (Work around(?) LD error: PHDR segment not covered by LOAD segment and Ignore incompatible-type errors). They point to real problems with newer toolchains, but the solutions might be problematic. EDIT: feel free to merge now |
Fixes this error: strip: Unable to recognise the format of the input file `stage1.elf'
Among the changes[1] in GNU ld 2.34 is this note: * The ld check for "PHDR segment not covered by LOAD segment" is more effective, catching cases that were wrongly allowed by previous versions of ld. If you see this error it is likely you are linking with a bad linker script or the binary you are building is not intended to be loaded by a dynamic loader. In the latter case --no-dynamic-linker is appropriate. [1]: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob_plain;f=ld/NEWS;hb=refs/heads/binutils-2_34-branch
Hi,
while trying to build maciNTosh in GitHub Actions CI, I ended up fixing a few things. Please take what you like :)