Skip to content

Commit

Permalink
Bump minimum pandas version from 0.20.3 to 0.23.0 (alteryx#216)
Browse files Browse the repository at this point in the history
* bump min pandas version from 0.20.3 to 0.23.0

* remove try/except for sort, since min version is 23
  • Loading branch information
Seth-Rothschild authored and kmax12 committed Aug 17, 2018
1 parent cca119c commit f74e7c3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
6 changes: 1 addition & 5 deletions featuretools/computational_backends/pandas_backend.py
Original file line number Diff line number Diff line change
Expand Up @@ -249,11 +249,7 @@ def calculate_all_features(self, instance_ids, time_last,
if missing_ids:
default_df = self.generate_default_df(instance_ids=missing_ids,
extra_columns=df.columns)
# pandas added sort parameter in 0.23.0
try:
df = df.append(default_df, sort=True)
except:
df = df.append(default_df)
df = df.append(default_df, sort=True)

df.index.name = self.entityset[self.target_eid].index
return df[[feat.get_name() for feat in self.features]]
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
numpy>=1.13.3
scipy>=1.0.0
pandas>=0.20.3
pandas>=0.23.0
s3fs>=0.1.2
tqdm>=4.19.2
toolz>=0.8.2
Expand Down

0 comments on commit f74e7c3

Please sign in to comment.