Skip to content

Comm node#3

Merged
goobta merged 10 commits intomasterfrom
comm_node
Feb 6, 2021
Merged

Comm node#3
goobta merged 10 commits intomasterfrom
comm_node

Conversation

@andrew103
Copy link
Member

Implement ROS node as an interface to the serial port and a node to test the interface with random data. Also includes empty comm_socket file that's unused currently

@andrew103 andrew103 self-assigned this Feb 3, 2021
@andrew103
Copy link
Member Author

Note: testing node doesn't explicitly try edge cases

Copy link
Member

@goobta goobta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments attached. Also, do we have tests for the logic? Testing serial ports is probably more hassle than its worth, but there's a lot of logic in com_socket that is super susceptible to off-by-one errors--it'd be nice to have the piece of mind that it all works :)

As always, gonna let @mahajanrevant give the final approval because he actually knows what's going on.

@andrew103
Copy link
Member Author

Comments attached. Also, do we have tests for the logic? Testing serial ports is probably more hassle than its worth, but there's a lot of logic in com_socket that is super susceptible to off-by-one errors--it'd be nice to have the piece of mind that it all works :)

As always, gonna let @mahajanrevant give the final approval because he actually knows what's going on.

Similar to the arduino setup, there aren't any tests that explicitly check the logic other than looking at the output on the other end. I could setup the testing node with a fixed set of values to send instead of random ones to be sure everything is correct.

Copy link
Contributor

@mahajanrevant mahajanrevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments for you to look at @andrew103.
@agupta231 give them a glance too

Copy link
Contributor

@mahajanrevant mahajanrevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!! I am going to approve it from my end. I have resolved the conversations but @agupta231 feel free to look at them. I am leaving this to you to merge it in

@goobta
Copy link
Member

goobta commented Feb 6, 2021

lgtm, we can address everything else in future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants