Breaking: Remove support for "Node-style" error-first callbacks #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintaining this node-style interface, which support threads indicate is rarely used (especially given the rising popularity of `async`/`await`), no longer outweights the benefit of providing a consistent interface regardless of the transport library used.
This completes the work to phase out the "node-style" error-first callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our original HTTP transport
superagentdoes not use Promises by default, so all versions of this library to date have supported Node-style error-first callbacks, e.g..get( ( err, data ) => { if ( err ) {} ... } ). However, Promises are the preferred and recommended way of using this library, and the vast majority of library consumers do not utilize the callback method signature.While evaluating additional transport providers, particularly
fetch, it became obvious that continuing to support callback-style asynchronous methods would be cumbersome with Promise-aware, modern transport methods likefetchor libraries likeaxios. As part of the slimming-down of our API for Version 2, this PR removes support for the node-style callback signature on all transport methods.