Skip to content

fix: Move CSS collection to generateBundle for Vite 6 & 7 compatibility #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dc-riskhub wants to merge 2 commits into
base: main
Choose a base branch
from
+39 −23
Open

fix: Move CSS collection to generateBundle for Vite 6 & 7 compatibility #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c9a730
fix: Move CSS collection to generateBundle for Vite 7 compatibility
dc-riskhub Jan 29, 2026
d1d5930
test: fix CSS map tests for generateBundle change
dc-riskhub Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 29 additions & 22 deletions src/plugin-factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,21 +350,45 @@ export function pluginFactory(readFileFn?: (path: string, options: any) => Promi
logData += markdownCodeBlock(formatData("options: %o", options));
logData += markdownCodeBlock(formatData("meta: %o", meta));
}
if (chunk.isEntry && !isRootConfig(config) && config.cssStrategy !== 'none') {
// Recursively collect all CSS files that this entry point might need.
// NOTE: CSS collection moved to generateBundle hook for Vite 7 compatibility.
// In Vite 7, viteMetadata.importedCss is not populated until after renderChunk completes.
}
catch (error) {
errorOccurred = true;
throw error;
}
finally {
await writeToLog(logData);
if (errorOccurred) {
await closeLog();
}
}
},
},
async generateBundle(_options, bundle, _isWrite) {
if (viteEnv.command === 'build') {
await closeLog();
}
if (!isRootConfig(config) && config.cssStrategy !== 'none') {
// Collect CSS files from entry chunks.
// This is done here instead of renderChunk because in Vite 7,
// viteMetadata.importedCss is not populated until after renderChunk.
for (let x in bundle) {
const chunk = bundle[x];
if (chunk.type === 'chunk' && chunk.isEntry) {
const cssFiles = new Set<string>();
const processedImports = new Set<string>();
const collectCssFiles = (curChunk: RenderedChunk) => {
if (!curChunk) {
return;
}
curChunk.viteMetadata?.importedCss.forEach(css => cssFiles.add(css));
for (let imp of curChunk.imports) {
curChunk.viteMetadata?.importedCss?.forEach(css => cssFiles.add(css));
for (let imp of curChunk.imports || []) {
if (processedImports.has(imp)) {
continue;
}
processedImports.add(imp);
collectCssFiles(meta.chunks[imp]);
collectCssFiles(bundle[imp] as RenderedChunk);
}
};
collectCssFiles(chunk);
Expand All @@ -374,23 +398,6 @@ export function pluginFactory(readFileFn?: (path: string, options: any) => Promi
}
}
}
catch (error) {
errorOccurred = true;
throw error;
}
finally {
await writeToLog(logData);
if (errorOccurred) {
await closeLog();
}
}
},
},
async generateBundle(_options, bundle, _isWrite) {
if (viteEnv.command === 'build') {
await closeLog();
}
if (!isRootConfig(config) && config.cssStrategy !== 'none') {
const stringifiedCssMap = JSON.stringify(JSON.stringify(cssMap));
for (let x in bundle) {
const entry = bundle[x];
Expand Down
11 changes: 10 additions & 1 deletion tests/plugin-factory.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,12 +525,21 @@ describe('vite-plugin-single-spa', () => {
for (let ch of chunks) {
await (plugIn.renderChunk as RenderChunkHandler).handler('', ch, {}, meta);
}
const bundle = {
// Build the bundle object with all chunks for generateBundle.
// In Vite 7+, CSS collection happens in generateBundle where viteMetadata.importedCss
// is fully populated, so the bundle must include all chunks with their metadata.
const bundle: Record<string, any> = {
'a.js': {
type: 'chunk',
code: '"{vpss:CSS_MAP}"'
}
};
for (let ch of chunks) {
bundle[ch.fileName] = {
...ch,
type: 'chunk'
};
}

// Act.
await (plugIn.generateBundle as GenerateBundleHandler)({}, bundle);
Expand Down