feat(Grade By Component): Show component average score #2112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tudents in the period for the component
breity
requested changes
Mar 12, 2025
There was a problem hiding this comment.
Looks good. Functionality works.
One suggestion: Maybe we shouldn't show the max score if there is no average score. For example, "N/A / 2 Mean Score" looks confusing. I think it would be better to just show "N/A Mean Score" like we do for the component score.
I will work on styling in #2090.
breity
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new feature for the grade by component feature branch.
This PR adds a new component, ComponentAverageScoreComponent, that shows the average score of the students in the period for the component. Previously, we were only able to show the average score for a node.
Changes
Test