Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name #83

Closed
annevk opened this issue Mar 19, 2021 · 36 comments · Fixed by #203
Closed

Name #83

annevk opened this issue Mar 19, 2021 · 36 comments · Fixed by #203
Labels
feedback wanted surface api Minor tweaks or additions to the API surface to make it nicer (without changing the model)

Comments

@annevk
Copy link

annevk commented Mar 19, 2021

I'm somewhat hesitant to raise this bikeshed, but #82 (comment) made me think it. Should it be named appHistory?

Perhaps appSession would reflect things a tiny bit better? (I guess the one potential confusing thing here is that it's not 1:1 with sessionStorage, but appHistory is not 1:1 with history either.)

@domenic
Copy link
Collaborator

domenic commented Mar 19, 2021

Yeah, app history is more of a "least bad" name. The predecessor proposal was called "navigator" and lived on window.history.navigator, but I thought that was pretty confusing.

"Session" seems like it might be the right spec-level concept to encompass "history and navigation", but it feels like the wrong web-dev-facing concept. When web devs talk about "sessions" it's mostly about user sessions, being logged in and out, etc., and not about history and navigation.

Between "history" and "navigation" I think most of the complexity (for web developers) comes in with history, so that's why I went with window.appHistory instead of window.appNavigator or window.historyAndNavigation or something. That does lead to confusion like #82 (comment) but that seems like an OK-ish price...

I'm happy to leave this open in case we come up with something brilliant. But my instincts are to stick with the inertia behind the current name, despite it not being perfect.

@domenic domenic added the surface api Minor tweaks or additions to the API surface to make it nicer (without changing the model) label Mar 19, 2021
@kidwm
Copy link

kidwm commented Mar 21, 2021

How about window.navigator.navigation or window.navigator.history?

@kenchris
Copy link

kenchris commented Mar 24, 2021

navigationHistory? navigationStack?

@tbondwilkinson
Copy link
Contributor

  • appSession: For me this is confusing, because it doesn't necessarily indicate it has to do with history or navigation or the URL, which are things that I think of when I think of this API.
  • window.navigator.navigation and window.navigator.history: I'm shaking my fist at the folks who got to navigator, because I think it has more to do with the User Agent than "navigation." But given that the existing window.navigator has little to do with navigation or history, I don't think it's right to hang this new API off that object.
  • navigationHistory: I think this is largely equivalent to appHistory, but not better.
  • navigationStack: People have quibbled about whether history is in fact a 'stack' (technically from a data structure POV, it's not), so I think I'd like to get away from this nomenclature.

@kenchris
Copy link

in appHistory, I am not sure what value "app" provides :-) at least "navigation history" provides a bit more clarification

@tbondwilkinson
Copy link
Contributor

Well, I suppose the "app" part is signifying to importance of same-origin history for this API - most of the new functionality has to do with enabling an "app" to inspect and modify its own history. So I'm not totally opposed to "app" being in the name.

But I do agree that if I had to pick one word to represent all this, it would be "navigation". Navigation to me represents the action that the API enables, "history" represents the state left behind by that action.

Not to throw another wrench, but other good words: "page", "view," "site". For instance, pageHistory (or pageNavigation), as opposed to appHistory, if no one likes the word app.

@Yay295
Copy link

Yay295 commented Mar 24, 2021

In that case it would be siteHistory, not pageHistory. A website can be composed of many webpages.

@uasan
Copy link

uasan commented Mar 26, 2021

Better - window.navigator.router

@domenic
Copy link
Collaborator

domenic commented May 12, 2021

@jakearchibald, @annevk, @smaug---- and I discussed this today. @smaug---- especially was of the opinion that this API is largely about navigation, and less so history. We tentatively thought that maybe just the name window.navigation (and spec title "Navigation API") would work:

await navigation.navigate(url);

const entries = navigation.entries();
const currentEntry = navigation.current; // or currentEntry? or now?

await navigation.transition.finished;

await navigation.back();
await navigation.goTo(key);

This seems pretty OK to me. What do other folks think?

@frehner
Copy link

frehner commented May 12, 2021

I like it.

Are there any chances of library/global conflicts? I tried doing some searching to see if anything puts navigation onto global/window but at first glance couldn't find anything.

@domenic
Copy link
Collaborator

domenic commented May 12, 2021

It's always hard to say, but generally on the web platform we haven't had many such conflicts. (The only one I'm aware of is when TC39 tried to introduce global, resulting in the current globalThis name.) We could also minimize the risk by making the global [Replaceable].

@bathos
Copy link

bathos commented May 12, 2021

Navigation is not a bad name, though it seem a lot more natural to call the-stateful-thing-you-call-navigate-on navigator, which — oh, wait, it seems that’s taken? perhaps this is not such a good name. :)

Can’t say I would look forward much to mistyping and misreading this all the time, and I’m a native speaker, so it may be more troublesome for others. AppHistory seemed fine to me — FWIW, the moment I saw that name, I knew what it was gonna be about, though I couldn’t nec explain why?

Of course this won’t make or break it but I do hope folks land on anything-but-navigation (because of navigator I mean — it seems fine conceptually).

(ActualNavigator?)

@Yay295
Copy link

Yay295 commented May 12, 2021

Unfortunately, I agree that "Navigation" may be too similar to the existing Navigator object (which ironically doesn't seem to have much to do with navigating). Perhaps "ApplicationState"?

@uasan
Copy link

uasan commented May 12, 2021

Maybe - window.navigator.app?

@jakearchibald
Copy link

jakearchibald commented May 13, 2021

I'd be happy with navigation or just nav. But in case we need another option:

Aside from just being better in a number of ways, there are two restrictions appHistory has vs history:

  • The exposed history is for the current frame only
  • The exposed history is limited to the current origin, contiguously

Based on that, there still isn't a name that jumps out at me, but here goes:

  • frameHistory/frameNav/frameNavigation - since the history is related to the frame. But, maybe frame sounds old and horrible, and it isn't clear that the top level is also a frame of sorts?
  • navigableHistory/navHistory - Assuming 'navigable' is a term we land on for "a thing that can be navigated".
  • originHistory - Although this doesn't make it clear that entries are limited to this navigable.

@bathos
Copy link

bathos commented May 13, 2021

Spitballing in case one of these clicks with people or, more likely, serves as a prompt.

  • Traverser
  • Traveller
  • BrowserNav
  • BrowserTimeline
  • Annals
  • Herstory
  • Historiographer
  • Ziggy

To be safe I’m not gonna make any claim about which of these are jokes and which I actually think are potentially good. If you hate them all, then they’re all jokes :)

@bathos
Copy link

bathos commented Jul 31, 2021

Placing this on the radar if it’s not already: the currently unqualified/unprefixed use of "navigate"/"nav" in global interface, operation, and event names in CSS Spatial Navigation proposal.

w3c/csswg-drafts#3387 (comment)

@domenic
Copy link
Collaborator

domenic commented Feb 23, 2022

Hey everyone,

After a half-year with no particularly better ideas, and a bit more offline discussion with @annevk and @smaug----, we think window.navigation is the best name on offer. This API really is about navigation, which encompasses history. All the other alternatives, e.g. variants on "history" or "traversal", fail to capture this scope.

The way in which the name starts with the same seven characters as navigator is unfortunate, but we think it'll be survivable.

This issue will remain open to track renaming everything (which will be fun 😬).

domenic added a commit to w3c/navigation-timing that referenced this issue Mar 8, 2022
This enum is too specific to the the navigation timing API and its idiosyncrasies to use the valuable name "NavigationType". In particular the API formerly known as app history (WICG/navigation-api#83) would like to use that name.
@domenic
Copy link
Collaborator

domenic commented Mar 8, 2022

I'm working on a draft spec PR, but I want to get some any feedback on the details of the rename as early as possible.

Noticeable developer-visible renames

  • window.appHistorywindow.navigation
  • appHistory.currentnavigation.currentEntry
    • currentchange event → currententrychange event
    • updateCurrent()updateCurrentEntry()
  • appHistory.goTo()navigation.traverseTo()

Class name changes

These are mostly not developer-impacting in mainstream code scenarios, but can impact e.g. feature detection. So we can make them longer and uglier if we want.

We should avoid changing them after shipping.

  • AppHistoryNavigation
  • AppHistoryTransitionNavigationTransition
  • AppHistoryEntryNavigationHistoryEntry
  • AppHistoryCurrentChangeEventNavigationCurrentEntryChangeEvent
  • AppHistoryNavigateEventNavigateEvent
  • AppHistoryDestinationNavigationDestination

Not-exposed IDL name changes

These names, for dictionaries and enums, are not something developers have any interaction with, and the only concern is clarity and avoiding collisions within the spec ecosystem. We can change them at any time.

  • AppHistoryUpdateCurrentOptionsNavigationUpdateCurrentEntryOptions
  • AppHistoryNavigationOptionsNavigationOptions
  • AppHistoryNavigateOptionsNavigationNavigateOptions
  • AppHistoryReloadOptionsNavigationReloadOptions
  • AppHistoryResultNavigationResult
  • AppHistoryNavigationTypeNavigationNavigationType (I would like this to be NavigationType; depends on Rename NavigationType to NavigationTimingType w3c/navigation-timing#172)

@frehner
Copy link

frehner commented Mar 8, 2022

AppHistoryEntry → HistoryEntry
AppHistoryCurrentChangeEvent → CurrentHistoryEntryChangeEvent

It seems a little strange to me that these don't have the word navigation in them and everything else developer-facing does. I also like the idea of having navigation in the name to help direct people what it's associated with.

AppHistoryUpdateCurrentOptions → UpdateCurrentHistoryEntryOptions
AppHistoryReloadOptions → ReloadOptions

Same here for these two, but maybe not as important because they're not dev-facing.

@domenic
Copy link
Collaborator

domenic commented Mar 8, 2022

Yeah, fair point, let me do some updates...

domenic added a commit that referenced this issue Mar 8, 2022
aarongable pushed a commit to chromium/chromium that referenced this issue Mar 16, 2022
See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications.

Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL.

This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments.

Bug: 1300246
Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981804}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Mar 16, 2022
See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications.

Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL.

This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments.

Bug: 1300246
Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981804}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Mar 16, 2022
See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications.

Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL.

This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments.

Bug: 1300246
Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981804}
aarongable pushed a commit to chromium/chromium that referenced this issue Mar 16, 2022
See WICG/navigation-api#83 and
WICG/navigation-api#203 for context.

This CL renames various "AppHistoryEntry" data structures and fields to
"NavigationApiHistoryEntry". This crosses the Blink/browser boundary.

Bug: 1300246
Change-Id: I878affd6c1ca2660b5d574bab8582467c9b51293
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523006
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981872}
aarongable pushed a commit to chromium/chromium that referenced this issue Mar 16, 2022
See WICG/navigation-api#83 and
WICG/navigation-api#203 for context.

This CL renames various fields of history entries, from "app history
key", "app history id", "app history state", and "protect URL in app
history" to their corresponding "navigation API" counterparts. This
crosses the Blink/browser boundary.

Bug: 1300246
Change-Id: Ifaf47859b49e971657c0e3c2217f1446b6a2bec0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523469
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981910}
aarongable pushed a commit to chromium/chromium that referenced this issue Mar 17, 2022
See WICG/navigation-api#83 and
WICG/navigation-api#203 for context.

This CL tidies up remaining references to app history across the
codebase, mostly in comments and in enum names. Some DOMException
messages also were forgotten in previous passes, and needed to be
updated.

Bug: 1300246
Change-Id: I10eeffb0cb6cc753679d45e450c8f5268bd500c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523471
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#982361}
aarongable pushed a commit to chromium/chromium that referenced this issue Mar 18, 2022
See WICG/navigation-api#83 and
WICG/navigation-api#203 for context.

This CL renames the Blink RuntimeEnabledFeature from AppHistory to
NavigationApi.

While here, we remove the origin_trial_feature_name key since the origin
trial is no longer relevant to tip-of-trunk code.

Bug: 1300246
Change-Id: I66dd86dce6d8bef7fa38353009fe6cea0cdbcf8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537549
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#982891}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 26, 2022
….yml, a=testonly

Automatic update from web-platform-tests
Adjust URL of the navigation API in its META.yml

This follows from change of spec name and title: WICG/navigation-api#83.

Further test updates, including renaming the directory, will happen in subsequent commits.
--

wpt-commits: b13358b272a2870388a1f0a82954c2a4189ad04f
wpt-pr: 33129
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 26, 2022
… (1/n), a=testonly

Automatic update from web-platform-tests
App history API to navigation API rename (1/n) (#33132)

See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL implements the following renames:

* window.appHistory → window.navigation
* appHistory.current → navigation.currentEntry
* appHistory.updateCurrent() → navigation.updateCurrentEntry()
* appHistory currentchange event → navigation currententrychange event
* appHistory.goTo() → navigation.traverseTo()

Notably, window.navigation has to be [Replaceable], as otherwise various internal tests that do `var navigation = ...` start failing.

No files are renamed at this point (including test files). No classes/IDL interfaces are renamed either.

Thus, the majority of this renaming is done in the web platform tests corpus, and to method names of the AppHistory C++ class.

Bug: 1300246
Change-Id: I29a01c6992c06a5d5099d831273ca8041281d557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510372
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#980648}

Co-authored-by: Domenic Denicola <domenic@chromium.org>
--

wpt-commits: 610b3657dbcfe8b740cfad0faaef7f1ad9897af8
wpt-pr: 33132
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 26, 2022
… (2/n), a=testonly

Automatic update from web-platform-tests
App history API to navigation API rename (2/n)

See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL renames all test files, with occasional minor updates to their contents. Notably this includes web platform test files.

While doing so, some of the web platform tests were slightly moved around to give a clearer directory structure. This revealed some confusing duplication (and in some cases mislocated tests) around state updates, which is tracked in https://crbug.com/1304446.

Bug: 1300246
Change-Id: Ieef0329e7a309c242b5391f050878bc182487905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510194
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#980702}

--

wpt-commits: 4e628b145e52797f421c7f832d13014387aac961
wpt-pr: 33182
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 26, 2022
… (3/n), a=testonly

Automatic update from web-platform-tests
App history API to navigation API rename (3/n)

See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications.

Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL.

This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments.

Bug: 1300246
Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981804}

--

wpt-commits: 3f00a909b6e15e281fe3dbbac376542465cc5232
wpt-pr: 33184
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 27, 2022
….yml, a=testonly

Automatic update from web-platform-tests
Adjust URL of the navigation API in its META.yml

This follows from change of spec name and title: WICG/navigation-api#83.

Further test updates, including renaming the directory, will happen in subsequent commits.
--

wpt-commits: b13358b272a2870388a1f0a82954c2a4189ad04f
wpt-pr: 33129
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 27, 2022
… (1/n), a=testonly

Automatic update from web-platform-tests
App history API to navigation API rename (1/n) (#33132)

See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL implements the following renames:

* window.appHistory → window.navigation
* appHistory.current → navigation.currentEntry
* appHistory.updateCurrent() → navigation.updateCurrentEntry()
* appHistory currentchange event → navigation currententrychange event
* appHistory.goTo() → navigation.traverseTo()

Notably, window.navigation has to be [Replaceable], as otherwise various internal tests that do `var navigation = ...` start failing.

No files are renamed at this point (including test files). No classes/IDL interfaces are renamed either.

Thus, the majority of this renaming is done in the web platform tests corpus, and to method names of the AppHistory C++ class.

Bug: 1300246
Change-Id: I29a01c6992c06a5d5099d831273ca8041281d557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510372
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#980648}

Co-authored-by: Domenic Denicola <domenic@chromium.org>
--

wpt-commits: 610b3657dbcfe8b740cfad0faaef7f1ad9897af8
wpt-pr: 33132
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 27, 2022
… (2/n), a=testonly

Automatic update from web-platform-tests
App history API to navigation API rename (2/n)

See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL renames all test files, with occasional minor updates to their contents. Notably this includes web platform test files.

While doing so, some of the web platform tests were slightly moved around to give a clearer directory structure. This revealed some confusing duplication (and in some cases mislocated tests) around state updates, which is tracked in https://crbug.com/1304446.

Bug: 1300246
Change-Id: Ieef0329e7a309c242b5391f050878bc182487905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510194
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#980702}

--

wpt-commits: 4e628b145e52797f421c7f832d13014387aac961
wpt-pr: 33182
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Mar 27, 2022
… (3/n), a=testonly

Automatic update from web-platform-tests
App history API to navigation API rename (3/n)

See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications.

Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL.

This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments.

Bug: 1300246
Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981804}

--

wpt-commits: 3f00a909b6e15e281fe3dbbac376542465cc5232
wpt-pr: 33184
aosmond pushed a commit to aosmond/gecko that referenced this issue Mar 28, 2022
….yml, a=testonly

Automatic update from web-platform-tests
Adjust URL of the navigation API in its META.yml

This follows from change of spec name and title: WICG/navigation-api#83.

Further test updates, including renaming the directory, will happen in subsequent commits.
--

wpt-commits: b13358b272a2870388a1f0a82954c2a4189ad04f
wpt-pr: 33129
aosmond pushed a commit to aosmond/gecko that referenced this issue Mar 28, 2022
… (1/n), a=testonly

Automatic update from web-platform-tests
App history API to navigation API rename (1/n) (#33132)

See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL implements the following renames:

* window.appHistory → window.navigation
* appHistory.current → navigation.currentEntry
* appHistory.updateCurrent() → navigation.updateCurrentEntry()
* appHistory currentchange event → navigation currententrychange event
* appHistory.goTo() → navigation.traverseTo()

Notably, window.navigation has to be [Replaceable], as otherwise various internal tests that do `var navigation = ...` start failing.

No files are renamed at this point (including test files). No classes/IDL interfaces are renamed either.

Thus, the majority of this renaming is done in the web platform tests corpus, and to method names of the AppHistory C++ class.

Bug: 1300246
Change-Id: I29a01c6992c06a5d5099d831273ca8041281d557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510372
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#980648}

Co-authored-by: Domenic Denicola <domenic@chromium.org>
--

wpt-commits: 610b3657dbcfe8b740cfad0faaef7f1ad9897af8
wpt-pr: 33132
aosmond pushed a commit to aosmond/gecko that referenced this issue Mar 28, 2022
… (2/n), a=testonly

Automatic update from web-platform-tests
App history API to navigation API rename (2/n)

See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL renames all test files, with occasional minor updates to their contents. Notably this includes web platform test files.

While doing so, some of the web platform tests were slightly moved around to give a clearer directory structure. This revealed some confusing duplication (and in some cases mislocated tests) around state updates, which is tracked in https://crbug.com/1304446.

Bug: 1300246
Change-Id: Ieef0329e7a309c242b5391f050878bc182487905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510194
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#980702}

--

wpt-commits: 4e628b145e52797f421c7f832d13014387aac961
wpt-pr: 33182
aosmond pushed a commit to aosmond/gecko that referenced this issue Mar 28, 2022
… (3/n), a=testonly

Automatic update from web-platform-tests
App history API to navigation API rename (3/n)

See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications.

Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL.

This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments.

Bug: 1300246
Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981804}

--

wpt-commits: 3f00a909b6e15e281fe3dbbac376542465cc5232
wpt-pr: 33184
aosmond pushed a commit to aosmond/gecko that referenced this issue Mar 28, 2022
….yml, a=testonly

Automatic update from web-platform-tests
Adjust URL of the navigation API in its META.yml

This follows from change of spec name and title: WICG/navigation-api#83.

Further test updates, including renaming the directory, will happen in subsequent commits.
--

wpt-commits: b13358b272a2870388a1f0a82954c2a4189ad04f
wpt-pr: 33129
aosmond pushed a commit to aosmond/gecko that referenced this issue Mar 28, 2022
… (1/n), a=testonly

Automatic update from web-platform-tests
App history API to navigation API rename (1/n) (#33132)

See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL implements the following renames:

* window.appHistory → window.navigation
* appHistory.current → navigation.currentEntry
* appHistory.updateCurrent() → navigation.updateCurrentEntry()
* appHistory currentchange event → navigation currententrychange event
* appHistory.goTo() → navigation.traverseTo()

Notably, window.navigation has to be [Replaceable], as otherwise various internal tests that do `var navigation = ...` start failing.

No files are renamed at this point (including test files). No classes/IDL interfaces are renamed either.

Thus, the majority of this renaming is done in the web platform tests corpus, and to method names of the AppHistory C++ class.

Bug: 1300246
Change-Id: I29a01c6992c06a5d5099d831273ca8041281d557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510372
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#980648}

Co-authored-by: Domenic Denicola <domenic@chromium.org>
--

wpt-commits: 610b3657dbcfe8b740cfad0faaef7f1ad9897af8
wpt-pr: 33132
aosmond pushed a commit to aosmond/gecko that referenced this issue Mar 28, 2022
… (2/n), a=testonly

Automatic update from web-platform-tests
App history API to navigation API rename (2/n)

See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL renames all test files, with occasional minor updates to their contents. Notably this includes web platform test files.

While doing so, some of the web platform tests were slightly moved around to give a clearer directory structure. This revealed some confusing duplication (and in some cases mislocated tests) around state updates, which is tracked in https://crbug.com/1304446.

Bug: 1300246
Change-Id: Ieef0329e7a309c242b5391f050878bc182487905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510194
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#980702}

--

wpt-commits: 4e628b145e52797f421c7f832d13014387aac961
wpt-pr: 33182
aosmond pushed a commit to aosmond/gecko that referenced this issue Mar 28, 2022
… (3/n), a=testonly

Automatic update from web-platform-tests
App history API to navigation API rename (3/n)

See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications.

Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL.

This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments.

Bug: 1300246
Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981804}

--

wpt-commits: 3f00a909b6e15e281fe3dbbac376542465cc5232
wpt-pr: 33184
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL implements the following renames:

* window.appHistory → window.navigation
* appHistory.current → navigation.currentEntry
* appHistory.updateCurrent() → navigation.updateCurrentEntry()
* appHistory currentchange event → navigation currententrychange event
* appHistory.goTo() → navigation.traverseTo()

Notably, window.navigation has to be [Replaceable], as otherwise various internal tests that do `var navigation = ...` start failing.

No files are renamed at this point (including test files). No classes/IDL interfaces are renamed either.

Thus, the majority of this renaming is done in the web platform tests corpus, and to method names of the AppHistory C++ class.

Bug: 1300246
Change-Id: I29a01c6992c06a5d5099d831273ca8041281d557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510372
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#980648}
NOKEYCHECK=True
GitOrigin-RevId: 3ccf5749316b2bf4dc8105c176233ce5f1620cfd
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL renames all test files, with occasional minor updates to their contents. Notably this includes web platform test files.

While doing so, some of the web platform tests were slightly moved around to give a clearer directory structure. This revealed some confusing duplication (and in some cases mislocated tests) around state updates, which is tracked in https://crbug.com/1304446.

Bug: 1300246
Change-Id: Ieef0329e7a309c242b5391f050878bc182487905
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3510194
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#980702}
NOKEYCHECK=True
GitOrigin-RevId: 302ac08d24813e79df5d17fbbea00e51815112d0
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
See WICG/navigation-api#83 and WICG/navigation-api#203 for context.

This CL is scoped mostly to the third_party/blink/renderer/core/app_history directory. That directory itself has been renamed from app_history to navigation_api. Its contents also follow the new naming. Notably, this includes changing all the IDL interface names and their backing classes, which has minor web-exposed implications.

Code outside of that directory is mostly updated due to the change from blink::AppHistory to blink::NavigationApi. References to app history still exist in Blink outside of that directory, as well as within Chromium at large; those will be tackled in a future CL.

This also finishes the process of updating the web platform tests, by both updating the actual test code for the interface renames, and updating various test descriptions and comments.

Bug: 1300246
Change-Id: I244e5fbb5d7977e8d61edae1e59d7bbfb6bdc75c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3522964
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981804}
NOKEYCHECK=True
GitOrigin-RevId: e65e212e00b19e814e56c697a7b67a5895916a10
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
See WICG/navigation-api#83 and
WICG/navigation-api#203 for context.

This CL renames various "AppHistoryEntry" data structures and fields to
"NavigationApiHistoryEntry". This crosses the Blink/browser boundary.

Bug: 1300246
Change-Id: I878affd6c1ca2660b5d574bab8582467c9b51293
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523006
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981872}
NOKEYCHECK=True
GitOrigin-RevId: cd30f5f8cd986ed1d95f12af2004b19f749eadb4
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
See WICG/navigation-api#83 and
WICG/navigation-api#203 for context.

This CL renames various fields of history entries, from "app history
key", "app history id", "app history state", and "protect URL in app
history" to their corresponding "navigation API" counterparts. This
crosses the Blink/browser boundary.

Bug: 1300246
Change-Id: Ifaf47859b49e971657c0e3c2217f1446b6a2bec0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523469
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981910}
NOKEYCHECK=True
GitOrigin-RevId: cc094fbd472dbee9952ae494907897bde03e695c
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
See WICG/navigation-api#83 and
WICG/navigation-api#203 for context.

This CL tidies up remaining references to app history across the
codebase, mostly in comments and in enum names. Some DOMException
messages also were forgotten in previous passes, and needed to be
updated.

Bug: 1300246
Change-Id: I10eeffb0cb6cc753679d45e450c8f5268bd500c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523471
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#982361}
NOKEYCHECK=True
GitOrigin-RevId: 3081074af94f0a75697fe86807e62ef7f1538b73
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
See WICG/navigation-api#83 and
WICG/navigation-api#203 for context.

This CL renames the Blink RuntimeEnabledFeature from AppHistory to
NavigationApi.

While here, we remove the origin_trial_feature_name key since the origin
trial is no longer relevant to tip-of-trunk code.

Bug: 1300246
Change-Id: I66dd86dce6d8bef7fa38353009fe6cea0cdbcf8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3537549
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#982891}
NOKEYCHECK=True
GitOrigin-RevId: 2e04818e615a118c8461ce53f3fc29dbf5526873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback wanted surface api Minor tweaks or additions to the API surface to make it nicer (without changing the model)
Projects
None yet
Development

Successfully merging a pull request may close this issue.