Relegate document.loadingMode to a potential future #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, the prerendering state API and other existing APIs should suffice. Related to #2.
bokand
approved these changes
Dec 8, 2020
browsing-context.md
Outdated
| if (document.visibilityState === "visible") { | ||
| videoElement.play(); | ||
| function afterPrerendering() { | ||
| // grab user data from cookies/IndexedDB |
There was a problem hiding this comment.
This and requesting notifications access seems better covered by the storage and permissions APIs above. More relevant to prerendering could be "start a video/animation", "fetch large resources", "connect to chat server", etc.
There was a problem hiding this comment.
Good call; leftover from some copy and pasting!
|
lgtm2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, the prerendering state API and other existing APIs should suffice. Related to #2.
@bokand, your review would be appreciated!