Skip to content

Conversation

@anediaz
Copy link

@anediaz anediaz commented Nov 15, 2025

Summary

This PR clarifies that previousRect and currentRect use CSS pixels, consistent with other Web Platform APIs like getBoundingClientRect(), IntersectionObserver, and ResizeObserver.

Changes:

  • Added note after LayoutShiftAttribution interface explaining CSS pixel usage
  • Updated "create the attribution" algorithm to explicitly specify CSS pixels

Implementation: https://chromium-review.googlesource.com/c/chromium/src/+/6624567
ChromeStatus: https://chromestatus.com/feature/5155103518228480


Preview | Diff

@anediaz
Copy link
Author

anediaz commented Dec 1, 2025

👋 Hi @skobes-chromium @npm1 @eyaich - requesting review of this spec clarification.

This PR documents that attribution rectangles use CSS pixels (not device pixels), aligning the spec with Chrome's implementation that shipped in early October.

Status:

cc @mmocny - would appreciate your review as the Layout Instability expert and the ultimate reviewer of this fix.

Happy to address any feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants