Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set permission query access algorithms #399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set permission query access algorithms #399

wants to merge 1 commit into from

Conversation

a-sully
Copy link
Collaborator

@a-sully a-sully commented Jan 12, 2023 •
edited by pr-preview bot
Loading

Follow-up to #392

This should officially wrap up #342

Preview | Diff

@a-sully
set permission query access algorithms
9b606fd 
Follow-up to WICG#392

This _should_ officially wrap up WICG#342
@a-sully
Copy link
Collaborator Author

a-sully commented Jan 12, 2023

This gives warnings when building locally because [=file system entry/request access=] and [=file system entry/query access=] aren't marked for export in whatwg spec. You'd put up a PR way back when (which I landed recently) to export all the necessary terms, but these terms weren't explicitly marked for export. I'm assuming that was a bug? Or is there another way I should be referencing these terms?

@a-sully a-sully mentioned this pull request Jan 17, 2023
Open
@a-sully a-sully changed the title Editorial: Set permission query access algorithms Set permission query access algorithms Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkruisselbrink mkruisselbrink Awaiting requested review from mkruisselbrink

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@a-sully