Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove data deprecation #125

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Conversation

pjaap
Copy link
Member

@pjaap pjaap commented Sep 9, 2024

This PR removes the support for Physics callbacks without a data argument.
See also #122

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (v2-state@86f7fb1). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/vfvm_physics.jl 75.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             v2-state     #125   +/-   ##
===========================================
  Coverage            ?   83.46%           
===========================================
  Files               ?       25           
  Lines               ?     2879           
  Branches            ?        0           
===========================================
  Hits                ?     2403           
  Misses              ?      476           
  Partials            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-fu
Copy link
Member

j-fu commented Sep 10, 2024

For me it would be ok to merge this into the v2-state branch. Can you do this ?

@j-fu j-fu merged commit e6e0e75 into WIAS-PDELib:v2-state Sep 10, 2024
6 of 12 checks passed
@pjaap pjaap deleted the remove-data-deprecation branch September 10, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants