use AbstractTransientSolution in GridVisualize stuff

WIAS-PDELib · Jul 11, 2023 · 3036e7e · 3036e7e · j-fu · Jul 11, 2023
1 parent 774ba7b
commit 3036e7e
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "VoronoiFVM"
 uuid = "82b139dc-5afc-11e9-35da-9b9bdfd336f3"
 authors = ["Jürgen Fuhrmann <juergen.fuhrmann@wias-berlin.de>", "Dilara Abdel", "Jan Weidner", "Alexander Seiler", "Patricio Farrell", "Matthias Liero"]
-version = "1.9.1"
+version = "1.10"
 
 [deps]
 BandedMatrices = "aae01518-5342-5314-be14-df237901396f"

diff --git a/docs/src/changes.md b/docs/src/changes.md
@@ -1,4 +1,6 @@
 # Changes
+## v1.10.0 July 11, 2023
+- Use AbstractTransientSolution in gridvisualize stuff
 
 ## v1.9.0 June 27, 2023
 - With `control.handle_exceptions=true`, in case of a failing step,

diff --git a/src/gridvisualize.jl b/src/gridvisualize.jl
@@ -38,7 +38,7 @@ end
 
 Plot one species from transient solution
 """
-function GridVisualize.scalarplot(sys::AbstractSystem, sol::TransientSolution; species = 1, scale=1.0, tscale=:identity, kwargs...)
+function GridVisualize.scalarplot(sys::AbstractSystem, sol::AbstractTransientSolution; species = 1, scale=1.0, tscale=:identity, kwargs...)
     @assert dim_space(grid) == 1
     vis = GridVisualizer(kwargs...)
     if !isnothing(vis.Plotter)
@@ -52,7 +52,7 @@ end
 
 Plot one species from transient solution
 """
-function GridVisualize.scalarplot!(vis, sys::AbstractSystem, sol::TransientSolution; species = 1,scale=1.0, tscale = :identity, tlabel = "t",
+function GridVisualize.scalarplot!(vis, sys::AbstractSystem, sol::AbstractTransientSolution; species = 1,scale=1.0, tscale = :identity, tlabel = "t",
                                    kwargs...)
     if !isnothing(vis)
         grid = sys.grid

diff --git a/src/vfvm_transientsolution.jl b/src/vfvm_transientsolution.jl
@@ -40,14 +40,14 @@ mutable struct TransientSolution{T, N, A, B} <: AbstractTransientSolution{T, N,
 end
 
 function TransientSolution(vec::AbstractVector{T}, ts, ::NTuple{N}) where {T, N}
-    TransientSolution{eltype(T), N, typeof(vec), typeof(ts)}(vec, ts)
+    TransientSolution{T, N, typeof(vec), typeof(ts)}(vec, ts)
 end
 
 TransientSolution(vec::AbstractVector, ts::AbstractVector) = TransientSolution(vec, ts, (size(vec[1])..., length(vec)))
 
-Base.append!(s::TransientSolution, t::Real, sol::AbstractArray) = push!(s.t, t), push!(s.u, copy(sol))
+Base.append!(s::AbstractTransientSolution, t::Real, sol::AbstractArray) = push!(s.t, t), push!(s.u, copy(sol))
 
-(sol::TransientSolution)(t) = _interpolate(sol, t)
+(sol::AbstractTransientSolution)(t) = _interpolate(sol, t)
 
 function _interpolate(sol, t)
     if isapprox(t, sol.t[1]; atol = 1.0e-10 * abs(sol.t[2] - sol.t[1]))
@@ -126,7 +126,7 @@ function VectorOfDiskArrays(obj::AbstractArray{T}; keep_open = true, fname = _te
     v
 end
 
-function Base.append!(s::TransientSolution{T, N, VectorOfDiskArrays{T}, B}, t::Real, sol::AbstractArray) where {T, N, B}
+function Base.append!(s::AbstractTransientSolution{T, N, VectorOfDiskArrays{T}, B}, t::Real, sol::AbstractArray) where {T, N, B}
     push!(s.t, t), push!(s.u, sol)
 end