Adds Fedora record removal to DeletePhysicalInstantiations fix #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afred
force-pushed
the
854-more-more-more-delete-Fedora-hangers-on
branch
from
1e72e96
to
3bcb39e
Compare
afred
force-pushed
the
854-more-more-more-delete-Fedora-hangers-on
branch
from
3bcb39e
to
c72ab04
Compare
afred
force-pushed
the
854-more-more-more-delete-Fedora-hangers-on
branch
from
c72ab04
to
e95c5b8
Compare
afred
force-pushed
the
854-more-more-more-delete-Fedora-hangers-on
branch
from
e95c5b8
to
ddaf04d
Compare
afred
force-pushed
the
854-more-more-more-delete-Fedora-hangers-on
branch
2 times, most recently
from
027cfd9
to
7fbff53
Compare
afred
force-pushed
the
854-more-more-more-delete-Fedora-hangers-on
branch
from
7fbff53
to
54ee1e2
Compare
afred
force-pushed
the
854-more-more-more-delete-Fedora-hangers-on
branch
from
54ee1e2
to
5574158
Compare
afred
force-pushed
the
854-more-more-more-delete-Fedora-hangers-on
branch
2 times, most recently
from
26bd483
to
4010868
Compare
Fedora records were not being deleted and were then being retreived by PhysicalInstantiationResource models, effectively getting stuck on the parent Asset. This allows the Fix::DeletePhysicalInstantiaton class to remove PhysicalInstantiations of a give media type from a set of AssetResources identified by an ID list. Usage Includes class SampleData class for finding test data sets within an existing repository (e.g. demo).
afred
force-pushed
the
854-more-more-more-delete-Fedora-hangers-on
branch
from
4010868
to
5f46e37
Compare
afred
requested review from
orangewolf and
bkiahstroud
and removed request for
orangewolf
bkiahstroud
reviewed
Nov 10, 2024
Comment on lines
+21
to
+27
| @members ||= [] | ||
| member_id_vals = member_ids.map { |id| id.to_s }.to_set | ||
| ids_from_members = @members.map { |m| m.id.to_s }.to_set | ||
| # If the member_ids do not match the IDs within the members, then re-set the members to be an accurate reflection of the member IDs. | ||
| # This allows us to modify resource.member_ids and have #members accurately reflect the changes. | ||
| if member_id_vals != ids_from_members | ||
| @members = member_ids.map do |id| |
There was a problem hiding this comment.
Can you explain more about what's happening on these lines and why?
| def destroy_work_and_members(resource:) | ||
| result = { resource: resource } | ||
| resource.members.each do |member| | ||
| resource.members.delete(member) |
There was a problem hiding this comment.
Can you please explain the purpose of this line? (28)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.