Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alert storm mail template #1422

Draft
wants to merge 10 commits into
base: feature/add-new-AA-storm
Choose a base branch
from

Conversation

Doniaab
Copy link
Collaborator

@Doniaab Doniaab commented Jan 28, 2025

Description

Template for tropical storm mail alert. made with simple css to ensure compatibility.

Capture d’écran du 2025-01-28 18-46-35

How to test the feature:

  • [ ]
  • [ ]

Checklist - did you ...

Test your changes with

  • REACT_APP_COUNTRY=rbd yarn start
  • REACT_APP_COUNTRY=cambodia yarn start
  • REACT_APP_COUNTRY=mozambique yarn start
  • Add / update necessary tests?
  • Add / update outdated documentation?

Screenshot/video of feature:

Copy link

github-actions bot commented Jan 28, 2025

Build succeeded and deployed at https://prism-1422.surge.sh
(hash 50b1499 deployed at 2025-01-30T22:08:30)

redirectUrl: data.redirectUrl,
base64Image: data.base64Image,
icons: {
mapIcon: `data:image/png;base64,${encodeImageToBase64('icons/mapIcon.png')}`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if you import the file directly? Doesnt it get loaded as base64?
See wmonk/create-react-app-typescript#337 (but maybe we're using a different loader)
I am just a bit worried of creating a custom function and creating a public folder just for this.

If the above does not work, how would you feel about creating an image folder instead with the icons and an index.ts that has the image util logic and exports the ready to use icons?

@@ -166,7 +165,10 @@ async function captureScreenshotFromUrl(options: ScreenshotOptions): Promise<str
};

base64Image = await page.screenshot({
Copy link
Collaborator

@ericboucher ericboucher Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename the variable if it's not returned as base64 anymore?

@ericboucher
Copy link
Collaborator

Great work! I just have a small concern about how we handle icons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants