Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors when loading storm layer #1419

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

Doniaab
Copy link
Collaborator

@Doniaab Doniaab commented Jan 28, 2025

Description

The error occurred because some layers were being added before the layer "aa-storm-wind-points-layer", which had not yet been defined.

Error: Cannot add layer "aa-storm-wind-points-line-future" before non-existing layer "aa-storm-wind-points-layer".

This was fixed by ensuring that all referenced layers, such as "aa-storm-wind-points-layer", are declared before using them in the beforeId property for other layers.

How to test the feature:

  • [ ]
  • [ ]

Checklist - did you ...

Test your changes with

  • REACT_APP_COUNTRY=rbd yarn start
  • REACT_APP_COUNTRY=cambodia yarn start
  • REACT_APP_COUNTRY=mozambique yarn start
  • Add / update necessary tests?
  • Add / update outdated documentation?

Screenshot/video of feature:

Copy link

github-actions bot commented Jan 28, 2025

Build succeeded and deployed at https://prism-1419.surge.sh
(hash 233eb43 deployed at 2025-01-28T16:11:22)

@ericboucher ericboucher marked this pull request as ready for review January 28, 2025 15:25
@ericboucher ericboucher merged commit f393e8a into feature/add-new-AA-storm Jan 28, 2025
6 checks passed
@ericboucher ericboucher deleted the fix/load-layer branch January 28, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants