Aa storm feature/use local time #1415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max-Z80
force-pushed
the
aa-storm-feature/use-local-time
branch
from
4c3bc28 to
6557c99
Compare
|
Build succeeded and deployed at https://prism-1415.surge.sh |
Doniaab
reviewed
Jan 21, 2025
| * When additional countries will need to access this module, this function will have to be revisited | ||
| */ | ||
|
|
||
| function formatInLocalTime(date: Date, fmt: string): string { |
There was a problem hiding this comment.
Maybe we could pass a timezone parameter with default value like this to be more generic even if we just need the mozambic time for now :
export function formatInLocalTime(date: Date, fmt: string, timeZone: string = 'Africa/Blantyre'): string {
const dateInLocalTime = utcToZonedTime(date, timeZone);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to test the feature:
Checklist - did you ...
Test your changes with
REACT_APP_COUNTRY=rbd yarn startREACT_APP_COUNTRY=cambodia yarn startREACT_APP_COUNTRY=mozambique yarn startScreenshot/video of feature: