-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check and externalize explicit sparql queries #1284 #1487
check and externalize explicit sparql queries #1284 #1487
Conversation
Sorry, about the name pattern of the files not being clear. It should be aspect_panel-description, e.g., |
|
Files called "empty" should be "index" instead, e.g., "work-index" and "pathway-index". Sorry again |
|
@fnielsen In this case the html is called "award_curation.html". Do I still assign it in aspect as "award-curation"? no matter if the html file uses "_" or "-"? |
@fnielsen Do you want to change the name only in the |
All HTML and sparql files should be called with a dash instead of an underscore |
11c7148
to
4548191
Compare
@fnielsen do you also require this caption here? |
e83cb81
to
92abc8b
Compare
I am not sure what you mean? |
I refer to the caption shown in the red box. The function that shows the diagram does not a code implemented to display the I put it to keep the format as the other externalizations. You can see the changes in this commit: a37c600 |
No a caption there is not necessary, I think. The rendering does not come from Wikimedia services, but from a thirdparty service, available at https://pathway-viewer.toolforge.org/?id=WP111 . I do not think they construct the visualization with SPARQL. |
A new js function and macro was created for topics-works-matrix in author.
A new js function and macro was created for pathwat viewer
A new js function and macro was created for 404_chemical. The query require to short the inchikey
92abc8b
to
ded489f
Compare
|
related #1283, #1282, #785
Externalize explicit sparql queries
Converting the explicit queries (tables) first to externalized query format. For example, files who have the following queries:
This PR solves partially the issue #1284.
The following files still have explicit queries:
Some annotations
index
but the name of html file will be the same for the moment. For example,use_empty.html
have an aspect nameduse-index
. The name of these html will be change in other PRauthor.html
,pathway.html
and404_chemical.html
required the creation of new macros and custom JS functions for extracting queries to external .sparql files