Refactor/phu specific templates #93
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c templates and update asset directory paths
Member
Author
|
Note this is a draft pr! Still more to add here. |
…der info for English and French templates
…derer calls with consistent indentation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
jangevaare
reviewed
Nov 12, 2025
Comment on lines
+76
to
+89
| TEMPLATE_MODULE_MAP = { | ||
| # shared test templates package | ||
| "templates": { | ||
| Language.ENGLISH.value: "en_template", | ||
| Language.FRENCH.value: "fr_template", | ||
| }, | ||
| # PHU-specific templates package (production) | ||
| "phu_templates": { | ||
| # PHU repo uses a different module name for English templates | ||
| Language.ENGLISH.value: "en_template_row", | ||
| # If a PHU-specific French template exists name it here, otherwise | ||
| # the code will fall back to the shared `templates` package. | ||
| Language.FRENCH.value: "fr_template", | ||
| }, |
Member
There was a problem hiding this comment.
This should perhaps be in config if needed
| columns: (50%,50%), | ||
| gutter: 5%, | ||
| [#image(logo, width: 6cm)], | ||
| [#image(logo, width: logo_width)], |
Collaborator
There was a problem hiding this comment.
is logo width and envelope width coming from config file?
| // Immunization Notice Section | ||
| #let immunization_notice(client, client_id, immunizations_due, date, font_size) = block[ | ||
| #v(0.2cm) |
Collaborator
There was a problem hiding this comment.
Can these hard coded values 6cm and 81pt come from parameters?
Member
|
Closed with #111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for switching between test mode (default) and production/PHU-specific mode in the pipeline, allowing dynamic selection of template packages and assets. The main changes include adding CLI flags to control the mode, refactoring template renderer selection to be dynamic, and updating Typst template functions for greater flexibility.
Test/Production mode support:
--test-modeand--no-test-modetopipeline/orchestrator.py, allowing users to toggle between test mode (shared templates/assets) and production mode (PHU-specific templates/assets). The default is test mode. [1] [2] [3]Dynamic template renderer selection:
pipeline/generate_notices.pyto import template renderers dynamically at runtime, based on the selected template package (templatesorphu_templates), instead of hardcoding imports. This includes a new function_import_rendererand a mapping for module names. [1] [2] [3]render_notice,generate_typst_files,main) to accept atemplates_packageargument and use the dynamic renderer selection. [1] [2] [3] [4] [5] [6] [7]Typst template improvements:
templates/conf.typand usage in template files to accept a configurablelogo_widthandenvelope_window_heightfor more flexible rendering. [1] [2] [3] [4] [5] [6] [7] [8]Testing and coverage:
templates_packageargument when retrieving language renderers, ensuring compatibility with the refactored API. [1] [2] [3] [4]printstatements from coverage inpyproject.toml.Documentation:
README.mdexplaining the test/production modes, CLI usage, and import path requirements for template packages.