Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and sync with Open Liberty Operator #19

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Update and sync with Open Liberty Operator #19

merged 2 commits into from
Mar 9, 2022

Conversation

arturdzm
Copy link
Contributor

@arturdzm arturdzm commented Mar 7, 2022

PR for #9

@arturdzm arturdzm force-pushed the wlo-base branch 2 times, most recently from 21742fa to 42d470e Compare March 7, 2022 15:21
Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arturdzm Thanks for the PR. Looks good. Some updates needed. If possible, please submit suggested changes via a separate commit, so it'll be easy to review just that. Thanks.

  • There are few references to olo- in e2e.sh and e2e-minikube.sh

  • config/manifests/kustomization.yaml: Websphere-liberty.v0.0.0 should be websphere-liberty.v0.0.0 (x-descriptor for service binding secret is missing from bundle's CSV due to this)

  • registry.connect.redhat.com/ibm/websphere-liberty-samples:springPetClinic should be registry.connect.redhat.com/ibm/open-liberty-samples:springPetClinic

  • description section in bundle's CSV is specified twice. The content is added from an *.md file now (Jason added some changes). Deleting the description section from config/manifests/bases/websphere-liberty.clusterserviceversion.yaml and generating bundle should resolve it.

  • controllers/webspherelibertyapplication_controller.go - following value should be finalizer.webspherelibertyapplications.liberty.websphere.ibm.com

const applicationFinalizer = "finalizer.liberty.websphere.ibm.com"
  • main.go: it should include liberty I believe Below value is fine (Leo)
    LeaderElectionID: “7111f50b.websphere.ibm.com”,
  • please change image references cp.stg.icr.io/websphere-liberty-operator to icr.io/cpopen/websphere-liberty-operator

Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arturdzm Looks good. Thank you.

@leochr leochr merged commit 5b020fd into main Mar 9, 2022
@leochr leochr deleted the wlo-base branch March 9, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants