added tryparse to default an invalid weight to zero

W3SS · Sep 20, 2014 · 8f5d044 · 8f5d044
1 parent 856821f
commit 8f5d044
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/Jump.Location.Specs/FileStoreProviderSpec.cs b/Jump.Location.Specs/FileStoreProviderSpec.cs
@@ -54,6 +54,19 @@ public void It_can_Revive_multiple_records_of_correctly_formatted_text()
                 db.Records.Count().ShouldEqual(3);
             }
 
+            [Fact]
+            public void It_can_Revive_a_record_with_invalid_weight()
+            {
+                var lines = new[] {"INVALID_WEIGHT\tFS::C:\\blah"};
+                File.WriteAllLines(path, lines);
+                var provider = new FileStoreProvider(path);
+
+                var db = provider.Revive();
+                db.Records.Count().ShouldEqual(1);
+                db.Records.First().Weight.ShouldEqual(0M);
+                db.Records.First().Path.ShouldEqual("C:\\blah");
+            }
+
             [Fact]
             public void It_skips_blank_and_empty_lines()
             {

diff --git a/Jump.Location/FileStoreProvider.cs b/Jump.Location/FileStoreProvider.cs
@@ -67,7 +67,8 @@ public IDatabase Revive()
                 if (columns == null || columns.Length != 2)
                     throw new InvalidOperationException("Row of file didn't have 2 columns separated by a tab");
 
-                var weight = decimal.Parse(columns[0], CultureInfo.InvariantCulture);
+                var weight = 0M;
+                decimal.TryParse(columns[0], NumberStyles.Any, CultureInfo.InvariantCulture, out weight);
                 var record = new Record(columns[1], weight);
                 db.Add(record);
             }