Skip to content

Conversation

@Mauzis01
Copy link

No description provided.

@Mauzis01 Mauzis01 requested a review from m-shariq August 26, 2024 07:36
@Mauzis01 Mauzis01 self-assigned this Aug 26, 2024
Copy link

@bismapervaiz bismapervaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please discuss the breaking changes as a proper changelog with Shariq.

cfg=cfg,
seed=seed,
neg_prompt=neg_prompt,
high_res_results=int(high_res_results),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc the conversion of boolean to int for usage.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving this change as it is as discussed

)

status_code, content = self.__client.post(
self.__endpoint, parameters, files=files

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pick 1 convention and follow everywhere, other handlers have inline and unnamed params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants