Rework of the Python Filter (Depends on PR Support UDP TCP #224) #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plied on the dga filter for now
If more than 1 certitude is sent back to client AND a body is set, the body is copied on the memory location of the certitudes It is fixed by using the correct offset when copying the body data. The other function using similar logic has been modified to keep it coherent.
UnixSessions are spawn by UnixServer and TcpSessions by TcpServer Included a modification when passing arguments from sessions to task (move instead of ref)
- Used to pass needed data from Session to Task
(some work is still need for the tasks)
State accessible by const getters only State mutable with only two methods : add Certitude and mutateBody
Added a few methods for DarwinPacket
Added ParseBody in ATask::run with error handling
Fixed issues with threadpool instance and size issues in the ASession
Fixed issues in the serialization Added support for ipv6 in Tcp sessions
Adapted python manager to handle tcp sockets
The packet was illformed near the certitudes NextFilterConnector: Working WIP
Abstract/Tcp/Unix, fixed configuration for nextFilter
- DarwinPacket copied only the first 15 bytes of event id - Destructor of AServer wasn't virtual leading to memory leak when UnixServer was destroyed
Service.update did not update nettwork field
Added retry attempts, modified tests accordingly
Proprietary filters needed additional methods for accessing private fields of a packet
Added possibility to run all tests in TCP mode
Assured working with ipv4 and ipv6 addresses Fixed a few log lines in the redis test file
Fixed a few problems and cleaned some code Added tests for tcp and udp Added possibility to run all test in unix or tcp
Removed unused methods
Specification of move semantic for DarwinPacket
Fixed a fex things accordingly
EvtIdToString passed from Session to DarwinPacket
Also cleaned ASession a bit
added packed attribute to darwin header Removed certitude list default size Modified parsing and serializing accordingly
Most case were unused variables or poorly chosen types
Fixed issue with positional flags between test/manager and filters
frikilax
reviewed
Feb 4, 2022
| } | ||
| } | ||
| for(auto cert: resp.certitudes) { | ||
| _packet.AddCertitude(cert); |
There was a problem hiding this comment.
stats' support might be complicated with this filter, bu I think you could add a STAT_MATCH_INC; for each certitude over threshold
There was a problem hiding this comment.
I added it
example.py is made a better example to test the filter Added logger to example added support for venv updated cmake min version
- now expects a class (see algorithm_module.py) - added tests for class specific issues
frikilax
force-pushed
the
support_tcp_udp
branch
from
c6352dd to
32066c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Pull Request Template
📃 Type of change
Please delete options that are not relevant.
Breaking change: fix or feature that would cause existing functionality to not work as expected.
💡 Related Issue(s)
✒️ Description
Reworks the python filter to be closer of what we need and easier to use.
🎯 Test Environments
FreeBSD - Vulture ISO (12.2)
Ubuntu (20.04)
✔️ Checklist: