Skip to content

Clean up the processor's dependencies slightly, and generate a shaded jar #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

niloc132
Copy link
Contributor

@niloc132 niloc132 commented Jun 6, 2019

From https://github.com/google/auto/tree/master/common#processor-resilience

Auto Common Utilities is used by a variety of annotation processors in Google and new versions may have breaking changes. Users of auto-common are urged to use shade or jarjar (or something similar) in packaging their processors so that conflicting versions of this library do not adversely interact with each other.

This is probably a good idea in general to follow - the config here is an attempt to combine the various dependencies of the processor, so that if another processor in a gwt project happens to use a different version of any of them, there won't be any conflicts.

Note that there are exclusions here, like vue-gwt core, and various jsinterop/elemental2 jars.

There are other benefits here too, like removing .java files from the classpath, so that the j2cl-maven-plugin won't think that those jars also need to be transpiled.

Finally, auto-service was mistakenly added as a scope=compile dependency, when it only is needed at compile time. As a result of this, I discovered that there is an implicit dependency on auto-common, so I added that directly.

@niloc132 niloc132 force-pushed the annotation-processor-dependencies branch from 1312816 to bfc4c1c Compare June 6, 2019 03:31
@adrienbaron adrienbaron merged commit c19b95d into VueGWT:develop Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants