Allowed PhysicalFile attributes to be set using known attribute names #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #312.
I've added an overload to
PhysicalFile .TrySetAttributeAsyncwhere you can pass in an enum value instead of a string for the property name. This allows unusual attribute names (such as{ItemType}, which maps to the build action) to be easily specified.I've also changed the
valueparameter to be an object, which allowsboolor enum values to be passed in rather than having the caller convert the value to a string.Examples:
I got the list of attributes by getting the property descriptors from a C# file (using the same code that's used in
TrySetAttributeAsync), and ignoring any that were read-only.