Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Gtest fix #4657

Merged
merged 36 commits into from
Nov 1, 2023
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
e4d1e6d
test
bassmang Oct 30, 2023
9caee56
rm
bassmang Oct 30, 2023
a390c91
upgrade googletest
bassmang Oct 30, 2023
76c831f
ts
bassmang Oct 30, 2023
3a7230f
Update VowpalWabbitUtils.cmake
bassmang Oct 30, 2023
4c74a79
libc++
bassmang Oct 30, 2023
efdab0e
only for clang
bassmang Oct 30, 2023
5192ea3
install clang builds
bassmang Oct 30, 2023
a6065de
revert
bassmang Oct 30, 2023
4c25e49
remove clang
bassmang Oct 30, 2023
50871d0
try just 20
bassmang Oct 30, 2023
ac75f49
try v4
bassmang Oct 30, 2023
f4f6bb5
clang 15
bassmang Oct 30, 2023
480bb96
rm 20
bassmang Oct 30, 2023
5d9b6f1
include
bassmang Oct 30, 2023
e0c393c
ignore unused for eigen
bassmang Oct 30, 2023
a57435b
lint
bassmang Oct 30, 2023
901a19e
only for clang/gnu
bassmang Oct 31, 2023
5ab0e3e
ignore eigen unused
bassmang Oct 31, 2023
c935ffe
get target
bassmang Oct 31, 2023
59a7213
vw
bassmang Oct 31, 2023
ac81fc0
only for gf test
bassmang Oct 31, 2023
84301aa
fix
bassmang Oct 31, 2023
a7909ee
check test target built
bassmang Oct 31, 2023
9f8db04
try def clang
bassmang Oct 31, 2023
bbecb81
update apt-get
bassmang Oct 31, 2023
7583dd6
libc++ for clang
bassmang Oct 31, 2023
86a9097
clang15 for ubuntu 22
bassmang Oct 31, 2023
ff8b1b4
spell out matrix
bassmang Oct 31, 2023
02161bf
check g++ ve3rsion
bassmang Oct 31, 2023
d3ff85a
ep_dec fix
bassmang Oct 31, 2023
40c3b66
lint
bassmang Oct 31, 2023
bfc8e71
try 17 std
bassmang Nov 1, 2023
ff9a12a
rm named_labels include
bassmang Nov 1, 2023
00af24c
readd include
bassmang Nov 1, 2023
20145d8
revert settings.json
bassmang Nov 1, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
libc++ for clang
  • Loading branch information
bassmang committed Oct 31, 2023
commit 7583dd69bb9d137b66b2b69b1719dd347c136c46
36 changes: 20 additions & 16 deletions .github/workflows/vendor_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,26 +31,30 @@ jobs:
- name: Install requirements
run: |
sudo apt-get update
sudo apt-get install -y ninja-build libboost-test-dev
sudo apt-get install -y ninja-build libboost-test-dev libc++-dev libc++abi-dev
- name: Configure
env:
CC: ${{matrix.compiler.cc}}
CXX: ${{matrix.compiler.cxx}}
run: >
cmake -S . -B build -G Ninja
-DCMAKE_BUILD_TYPE=${{matrix.build_type}}
-DVW_FEAT_FLATBUFFERS=Off
-DVW_FEAT_CSV=On
-DVW_FEAT_CB_GRAPH_FEEDBACK=On
-DRAPIDJSON_SYS_DEP=Off
-DFMT_SYS_DEP=Off
-DSPDLOG_SYS_DEP=Off
-DVW_ZLIB_SYS_DEP=Off
-DVW_BOOST_MATH_SYS_DEP=Off
-DVW_INSTALL=Off
-DWARNINGS=On
-DWARNING_AS_ERROR=On
-DUSE_LATEST_STD=On
run: |
FLAGS=""
if [[ "${{ matrix.compiler.cxx }}" == "clang++" ]]; then
FLAGS="-DCMAKE_CXX_FLAGS=-stdlib=libc++"
fi
cmake -S . -B build -G Ninja $FLAGS \
-DCMAKE_BUILD_TYPE=${{matrix.build_type}} \
-DVW_FEAT_FLATBUFFERS=Off \
-DVW_FEAT_CSV=On \
-DVW_FEAT_CB_GRAPH_FEEDBACK=On \
-DRAPIDJSON_SYS_DEP=Off \
-DFMT_SYS_DEP=Off \
-DSPDLOG_SYS_DEP=Off \
-DVW_ZLIB_SYS_DEP=Off \
-DVW_BOOST_MATH_SYS_DEP=Off \
-DVW_INSTALL=Off \
-DWARNINGS=On \
-DWARNING_AS_ERROR=On \
-DUSE_LATEST_STD=On
- name: Build
run: cmake --build build
- name: Unit tests
Expand Down
Loading