Skip to content

Commit

Permalink
fix: coin's learn does not return a prediction, update to reflect
Browse files Browse the repository at this point in the history
The prediction it currently returns essentially represents what the prediction would have been post learn and therefore does not match the contract of learn_returns_prediction,
  • Loading branch information
jackgerrits authored Jul 7, 2023
1 parent 453f287 commit ea80274
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions vowpalwabbit/core/src/reductions/ftrl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ std::shared_ptr<VW::LEARNER::learner> VW::reductions::ftrl_setup(VW::setup_base_
all.output_config.audit || all.output_config.hash_inv ? learn_coin_betting<true> : learn_coin_betting<false>;
all.weights.stride_shift(3); // NOTE: for more parameter storage
b->ftrl_size = 6;
learn_returns_prediction = true;
learn_returns_prediction = false;
}

b->data.ftrl_alpha = b->ftrl_alpha;
Expand Down Expand Up @@ -498,4 +498,4 @@ std::shared_ptr<VW::LEARNER::learner> VW::reductions::ftrl_setup(VW::setup_base_
.set_print_update(VW::details::print_update_simple_label<ftrl>)
.build();
return l;
}
}

0 comments on commit ea80274

Please sign in to comment.