Bug-98 Use preference to store the last visit card position.#37
Conversation
874ea33 to
b13bd76
Compare
|
Hi, you had broke a unit test: exec] org.vosie.wikicards.test.CardActivityTest: |
There was a problem hiding this comment.
You forget to commit the editor. http://developer.android.com/reference/android/content/SharedPreferences.Editor.html
There was a problem hiding this comment.
Without commit(), the preferences only saved in memory instead of storage. So, this patch may not work correctly. BTW, I think this issue's priority is not high. You may take your time to fix it.
@john-hu please help me review this patch.Thank you.