VIDCS-3442: Refactor session context #155
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIDCS-3292: Push the new workflow and fixes to main
VIDCS-3367: Update main branch for VERA 1.0.1
VIDCS-3438: Update main branch for VERA 1.0.2
…ss, start replacing with class methods where appropriate
…with types. publishing works now.
…cpettet/vidcs-3442-refactor-session-context
…to cpettet/vidcs-3442-refactor-session-context
…ss, start replacing with class methods where appropriate
…with types. publishing works now.
…com:Vonage/vonage-video-react-app into cpettet/vidcs-3442-refactor-session-context
cpettet
commented
Apr 30, 2025
Comment on lines
-110
to
-117
| useEffect(() => { | ||
| session?.on('signal', emojiHandler); | ||
|
|
||
| return () => { | ||
| session?.off('signal', emojiHandler); | ||
| }; | ||
| }, [emojiHandler, session]); | ||
|
|
There was a problem hiding this comment.
We handle this in the session context. Removing this silences the event listener console warning.
cpettet
commented
Apr 30, 2025
Comment on lines
-55
to
-56
| changedStream: null | ChangedStreamType; | ||
| connections: null | Connection[]; |
There was a problem hiding this comment.
These two weren't used anywhere.
cpettet
commented
Apr 30, 2025
Comment on lines
251
to
268
| /** | ||
| * Handles the creation of a new connection. Adding it to the connection array | ||
| * @param {ConnectionEventType} e - The connection event object. | ||
| */ | ||
| const handleConnectionCreated = (e: ConnectionEventType) => { | ||
| setConnections((prevConnections) => [...prevConnections, e.connection]); | ||
| }; | ||
|
|
||
| /** | ||
| * Handles the destruction of a connection. Removing it from the connections array | ||
| * @param {ConnectionEventType} e - The connection event object. | ||
| */ | ||
| const handleConnectionDestroyed = (e: ConnectionEventType) => { | ||
| setConnections((prevConnections) => | ||
| [...prevConnections].filter( | ||
| (connection) => connection.connectionId !== e.connection.connectionId | ||
| ) | ||
| ); |
There was a problem hiding this comment.
These two weren't used at all. It may have been leftovers from our call data function from the beginning.
cpettet
force-pushed
the
cpettet/vidcs-3442-refactor-session-context
branch
2 times, most recently
from
2dbfba4 to
177d926
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Refactors the session context so that the Vonage Video API parts are inside a separate non-react, plain-old
JavaScriptTypeScript class. This will allow for easier testing in the future, e.g. captions 👀 . We talked about doing this since the pinning PR since that was running into issues with mocking.note: I force-pushed the wrong commit and had to open a new PR, some (addressed) comments are here: #140
How should this be manually tested?
What are the relevant tickets?
A maintainer will add this ticket number.
Resolves VIDCS-3442
Checklist
[✅] Branch is based on
develop(notmain).[ ] Resolves a
Known Issue.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?