Skip to content

VIDCS-3673: Z index issue when we have a full participants list and opening the kebab for last participants #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025
Merged

VIDCS-3673: Z index issue when we have a full participants list and opening the kebab for last participants #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/src/components/MeetingRoom/ParticipantListButton/ParticipantListButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ const ParticipantListButton = ({
backgroundColor: 'rgb(95, 99, 104)',
},
marginRight: '12px',
zIndex: 1,
Copy link
Preview

Copilot AI Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Verify that the z-index value of 1 is appropriate for the stacking context, and consider refactoring to use a theme-based constant for consistent UI layering across components.

Copilot uses AI. Check for mistakes.

}}
overlap="circular"
>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/MeetingRoom/ParticipantListItemMenu/ParticipantListItemMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const ParticipantListItemMenu = ({
<IconButton onClick={handleClick} sx={{ marginRight: '-8px' }}>
<MoreVertIcon sx={{ fontSize: '18px' }} />
</IconButton>
<Popper open={isOpen} anchorEl={anchorEl} placement="bottom-start">
<Popper open={isOpen} anchorEl={anchorEl} placement="bottom-start" sx={{ zIndex: 10 }}>
Copy link
Preview

Copilot AI Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider using a theme-based z-index constant instead of a magic number to maintain consistency with the rest of the UI and avoid potential conflicts with other components.

Copilot uses AI. Check for mistakes.

<ClickAwayListener onClickAway={handleClose}>
<Paper
elevation={4}
Expand Down
Loading