Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump off PHP 8.0, add support for next vonage jwt lib #462

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

SecondeJK
Copy link
Contributor

@SecondeJK SecondeJK commented Dec 19, 2023

This PR drops support for PHP8.0 and adds in dependency bumps for JWTs

Motivation and Context

Continued evolution of the SDK

How Has This Been Tested?

Dependency changes require that the existing test suite passes.

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dcd9651) 79.01% compared to head (0afb280) 79.01%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #462   +/-   ##
=========================================
  Coverage     79.01%   79.01%           
  Complexity     2337     2337           
=========================================
  Files           218      218           
  Lines          6281     6281           
=========================================
  Hits           4963     4963           
  Misses         1318     1318           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SecondeJK SecondeJK merged commit c0cd476 into main Dec 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants