feat: added additional WABA and WA ES Flow Endpoints #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superchilled
requested changes
Dec 4, 2025
Contributor
superchilled
left a comment
superchilled
left a comment
There was a problem hiding this comment.
This mostly looks good, just a few things to check/fix.
| -H 'Content-Type: application/json' \ | ||
| -H 'Accept: application/json' \ | ||
| -d $'{ | ||
| "solution_id": "123456789111213", |
Contributor
There was a problem hiding this comment.
Should this not be a variable?
| -H 'Accept: application/json' \ | ||
| -d $'{ | ||
| "solution_id": "123456789111213", | ||
| "api_key": "'${CHANNEL_MANAGER_WAHTSAPP_PARTNER_API_KEY}'", |
Contributor
There was a problem hiding this comment.
Typo
Suggested change
| "api_key": "'${CHANNEL_MANAGER_WAHTSAPP_PARTNER_API_KEY}'", | |
| "api_key": "'${CHANNEL_MANAGER_WHATSAPP_PARTNER_API_KEY}'", |
|
|
||
| source "../../config.sh" | ||
|
|
||
| curl -X PATCH https://api.nexmo.com/v1/channel-manager/whatsapp/wabas/${CHANNEL_MANAGER_WABA_ID}/numbers/${CHANNEL_MANAGER_WABA_NUMBER}/profile \ |
Contributor
There was a problem hiding this comment.
Is this the correct path? According to the spec it should be:
Suggested change
| curl -X PATCH https://api.nexmo.com/v1/channel-manager/whatsapp/wabas/${CHANNEL_MANAGER_WABA_ID}/numbers/${CHANNEL_MANAGER_WABA_NUMBER}/profile \ | |
| curl -X PATCH https://api.nexmo.com/v1/channel-manager/whatsapp/numbers/${CHANNEL_MANAGER_WABA_NUMBER}/profile \ |
unless the spec is wrong? 🤔
| CHANNEL_MANAGER_WHATSAPP_ANALYTICS_TEMPLATE_IDS=${CHANNEL_MANAGER_WHATSAPP_ANALYTICS_TEMPLATE_IDS:-"[]"} | ||
|
|
||
| ## WhatsApp Hosted ES FLow | ||
| CHANNEL_MANAGER_WAHTSAPP_PARTNER_API_KEY=${CHANNEL_MANAGER_WAHTSAPP_PARTNER_API_KEY:-""} |
Contributor
There was a problem hiding this comment.
Typo
Suggested change
| CHANNEL_MANAGER_WAHTSAPP_PARTNER_API_KEY=${CHANNEL_MANAGER_WAHTSAPP_PARTNER_API_KEY:-""} | |
| CHANNEL_MANAGER_WHATSAPP_PARTNER_API_KEY=${CHANNEL_MANAGER_WHATSAPP_PARTNER_API_KEY:-""} |
Contributor
There was a problem hiding this comment.
It looks like CHANNEL_MANAGER_WABA_NUMBER is missing from config.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the last remaining snippets for WA and Hosted ES Flow endpoints