Skip to content

Commit

Permalink
adding events for spinner shown/hidden
Browse files Browse the repository at this point in the history
Summary: adding more events to track when spinner gets shown and dismissed during DBL code generation flow

Differential Revision: D36420836

fbshipit-source-id: f7936a5c103939463d2b2bf64ba4dd874596e75c
  • Loading branch information
Roman Shakhmanaev authored and facebook-github-bot committed May 16, 2022
1 parent 5312bc2 commit 7599569
Showing 1 changed file with 19 additions and 3 deletions.
22 changes: 19 additions & 3 deletions facebook-common/src/main/java/com/facebook/login/LoginFragment.kt
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ open class LoginFragment : Fragment() {
private set
private var request: LoginClient.Request? = null

private lateinit var progressBar: View

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
val restoredLoginClient = savedInstanceState?.getParcelable<LoginClient>(SAVED_LOGIN_CLIENT)
Expand Down Expand Up @@ -81,15 +83,15 @@ open class LoginFragment : Fragment() {
savedInstanceState: Bundle?
): View? {
val view = inflater.inflate(layoutResId, container, false)
val progressBar = view.findViewById<View>(R.id.com_facebook_login_fragment_progress_bar)
progressBar = view.findViewById<View>(R.id.com_facebook_login_fragment_progress_bar)
loginClient.backgroundProcessingListener =
object : LoginClient.BackgroundProcessingListener {
override fun onBackgroundProcessingStarted() {
progressBar.visibility = View.VISIBLE
showSpinner()
}

override fun onBackgroundProcessingStopped() {
progressBar.visibility = View.GONE
hideSpinner()
}
}
return view
Expand Down Expand Up @@ -149,6 +151,20 @@ open class LoginFragment : Fragment() {
outState.putParcelable(SAVED_LOGIN_CLIENT, loginClient)
}

private fun showSpinner() {
progressBar.visibility = View.VISIBLE
onSpinnerShown()
}

private fun hideSpinner() {
progressBar.visibility = View.GONE
onSpinnerHidden()
}

protected open fun onSpinnerShown() {}

protected open fun onSpinnerHidden() {}

private fun initializeCallingPackage(activity: Activity) {
val componentName = activity.callingActivity ?: return
callingPackage = componentName.packageName
Expand Down

0 comments on commit 7599569

Please sign in to comment.