Feature/header and footer component #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j8seangel
changed the title
Closed
Contributor
|
I think the postcss-hexrgba plugin is not in the package.json because I can't install the project, can you please check? |
geriux
reviewed
Oct 27, 2016
| <defs> | ||
| <symbol id="logo-small" viewBox="0 0 209 30"> | ||
| <title>Logo small</title> | ||
| <g fill="none" fillRule="evenodd"> |
Contributor
There was a problem hiding this comment.
How are we going to manage the SVG icons? What about icomoon?
Contributor
Author
There was a problem hiding this comment.
That sounds good, do you want to add the .json project ?
Contributor
There was a problem hiding this comment.
Alright I'll add it to PT so I don't forget
Contributor
Author
|
Fix the missing dependency, I forgot |
geriux
approved these changes
Oct 27, 2016
Contributor
geriux
left a comment
geriux
left a comment
There was a problem hiding this comment.
Looking great! Let's keep in mind the thing about the icons!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Closed #2 because this PR contains it (please read notes).