Update plugins to use classes for initialisation. #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
May 26, 2018 18:25
VizuaaLOG
pushed a commit
that referenced
this pull request
Jun 23, 2019
* Update navbar to use classes * Convert the dropdown plugin to use classes * Update the accordion to include getRootClass * Update navbar to use classes * Convert the dropdown plugin to use classes * Update the accordion to include getRootClass * Update the file plugin to use classes * Update the message plugin to use classes * Update modal plugin to use classes * Update the notification plugin to use classes * Update the tabs plugin to use classes * JSDoc correction * Dev build latest to dist * Documentation updates. Closes #20 * Update navbar to use classes * Convert the dropdown plugin to use classes * Update the accordion to include getRootClass * Update the file plugin to use classes * Update the message plugin to use classes * Update modal plugin to use classes * Update the notification plugin to use classes * Update the tabs plugin to use classes * JSDoc correction * Dev build latest to dist * Documentation updates. Closes #20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this library is only for Bulma we can rely on the class names that are being used. This prevents the need for updating the HTML code in some cases. Helping BulmaJS being an easy drop-in replacement with minimal JS configuration.
Of course, some plugins do allow for a data attribute API to configure options, moving forward more plugins will also provide this.