Skip to content

Conversation

@Vizonex
Copy link
Owner

@Vizonex Vizonex commented Dec 11, 2025

What do these changes do?

Seems pycares is moving at a faster pace than I had originally anticipated
so I wrote some changes yesterday under a 5 hour period of time. It's not done yet and still
is prone to problems.

  • new dataclass setup
  • removes getsocks
  • looks at more logical import changes
  • parsing now takes place in the resulttypes module under c definitions
  • fallback to pycares's parsing under one callback but I may consider going back to our old methods of multiple callbacks in the future that filters out differences.

Are there changes in behavior for the user?

Is it a substantial burden for the maintainers to support this?

A little there's going to be a lot of code cleanup after 0.3.0

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist (Not finished yet)
  • Documentation reflects the changes (Not finished yet)

@Vizonex Vizonex marked this pull request as ready for review December 12, 2025 20:50
@Vizonex Vizonex merged commit 74b2933 into main Dec 12, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants