Update server.R #30
Open
Update server.R #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I propose the addition of stopApp(). It will ensure that whenever user closes the window when running the session locally, the shiny app and the server will be terminated. It is most visible when running from R Console or from Terminal using Rscript, which are still busy even after user closes the browser tab. I should probably add that this shouldn't be added to a publicly accessible, server-deployed app since closing the window will kill the whole app for every on-line user.
|
Thank you for this @krystianll - I apologise, we did not see your pull request until now. We will have to think about this since we deploy this version of the app to a server. We might have to have start maintaining two versions of the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose the addition of stopApp(). It will ensure that whenever user closes the window when running the session locally, the shiny app and the server will be terminated. It is most visible when running from R Console or from Terminal using Rscript, which are still busy even after user closes the browser tab.
I should probably add that this shouldn't be added to a publicly accessible, server-deployed app since closing the window will kill the whole app for every on-line user.