Create DeviceCompat for QuestCraft#317
Merged
ferriarnus merged 8 commits intoVivecraft:openxrfrom Nov 24, 2024
CADIndie:QCXR
Merged
Create DeviceCompat for QuestCraft#317ferriarnus merged 8 commits intoVivecraft:openxrfrom CADIndie:QCXR
ferriarnus merged 8 commits intoVivecraft:openxrfrom
CADIndie:QCXR
Conversation
Co-Authored-By: ferriarnus <61201275+ferriarnus@users.noreply.github.com> Co-Authored-By: The Judge <53906078+thejudge156@users.noreply.github.com>
Co-Authored-By: The Judge <53906078+thejudge156@users.noreply.github.com>
Member
|
Most of this makes sense, just a few questions:
|
Member
|
blank:lwjgl:openxr is their custom lwjgl build afaik |
fayer3
reviewed
Nov 21, 2024
common/src/main/java/org/vivecraft/client_vr/provider/openxr/MCOpenXR.java
Outdated
Show resolved
Hide resolved
Contributor
Author
As Fayer said, it's our custom OpenXR LWJGL lib, it's required because LWJGL doesn't include the required classes and bindings (mostly GLES stuff) by default, I had forgotten entirely to add it and make it the main library used 😅
Mostly an accident and biproduct of continuing from my changes in the #315 PR. |
thejudge156
added a commit
to thejudge156/VivecraftMod
that referenced
this pull request
Dec 2, 2024
* Fix Conformance Issues Co-Authored-By: ferriarnus <61201275+ferriarnus@users.noreply.github.com> Co-Authored-By: The Judge <53906078+thejudge156@users.noreply.github.com> * Create DeviceCompat for QuestCraft Co-Authored-By: The Judge <53906078+thejudge156@users.noreply.github.com> * fix lwjgl openxr version * Use Custom OpenXR Library * Switch to OpenXR 1.0.40 * Log Device Platform * Remove Discord from repo list --------- Co-authored-by: ferriarnus <61201275+ferriarnus@users.noreply.github.com> Co-authored-by: The Judge <53906078+thejudge156@users.noreply.github.com> Co-authored-by: fayer3 <bayer.florian@aon.at>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a new interface called DeviceCompat meant for easily switching between desktop and Android init info, additionally, this may be used later on to help with setting default options for QuestCraft (I.e Hide VR Toggle Button). This PR also adds VLoader, its used for passing info between Vivecraft and QuestCraft itself such as the EGL context and EGL display.