Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX #128: Button Fix #130

Merged
merged 1 commit into from
Jul 10, 2020
Merged

FIX #128: Button Fix #130

merged 1 commit into from
Jul 10, 2020

Conversation

smaharj1
Copy link
Collaborator

@smaharj1 smaharj1 commented Jul 3, 2020

What is this doing?
Fixing the weird button from issue #128 . Resolves #128

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe how it impacts the application:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. Fix #xxx[,#xxx], where "xxx" is the issue number)
  • New/updated tests are included

Other information:

@smaharj1 smaharj1 requested a review from Viveckh July 3, 2020 15:01
@smaharj1 smaharj1 self-assigned this Jul 3, 2020
@Viveckh Viveckh merged commit 186fc0a into develop Jul 10, 2020
@Viveckh Viveckh deleted the ui-fix-128 branch July 10, 2020 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Viveckh Viveckh Viveckh approved these changes

Assignees

@smaharj1 smaharj1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visual Bug
2 participants
@smaharj1 @Viveckh