Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #117: Order places not showing error #118

Merged
merged 1 commit into from
May 23, 2020
Merged

Conversation

smaharj1
Copy link
Collaborator

What is this doing?
Order places wasn't being shown in admin cause there was no pagination

  • Added Pagination
  • Tabs were somehow disappearing too. So, changed the logic there as well

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe how it impacts the application:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. Fix #xxx[,#xxx], where "xxx" is the issue number)
  • New/updated tests are included

Other information:

- Added Pagination
- Tabs were somehow disappearing too. So, changed the logic there as well
@smaharj1 smaharj1 self-assigned this May 23, 2020
@smaharj1 smaharj1 requested a review from Viveckh May 23, 2020 20:19
@smaharj1 smaharj1 linked an issue May 23, 2020 that may be closed by this pull request
@Viveckh Viveckh merged commit 28e8358 into develop May 23, 2020
@Viveckh Viveckh deleted the fix/order-not-showing branch May 23, 2020 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New order does not show in admin dashboard
2 participants