Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #110: deleting product after being paid #111

Merged
merged 1 commit into from
May 3, 2020

Conversation

smaharj1
Copy link
Collaborator

@smaharj1 smaharj1 commented May 3, 2020

What is this doing?
Fixes #110 where product isn't deleted after the order is placed. Also, fixed the UI for order detail page.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe how it impacts the application:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. Fix #xxx[,#xxx], where "xxx" is the issue number)
  • New/updated tests are included

Other information:

@smaharj1 smaharj1 requested a review from Viveckh May 3, 2020 16:44
@smaharj1 smaharj1 self-assigned this May 3, 2020
@Viveckh Viveckh merged commit 197c6b2 into develop May 3, 2020
@Viveckh Viveckh deleted the product-deletion-paid branch July 17, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG
2 participants