Skip to content

Conversation

@deril2605
Copy link
Contributor

@deril2605 deril2605 commented May 20, 2024

Adding new Plotly library to MSstatsPTM to render Plotly plots back to MSstatsShiny app. The new parameter isPlotly to dataProcessPlotsPTM and groupComparisonPlotsPTM function handles this. If isPlotly is set to FALSE, it behaves normally (renders ggPlots).

In git diff, all the lines in the files appears to be changed. Devon and I identified this problem as issues with line endings. Below is a possible approach to fix it

There is this homebrew package dos2unix that converts file endings to what we need. Here is a test that I did

@deril2605 deril2605 self-assigned this May 20, 2024
@devonjkohler devonjkohler merged commit c18fb1c into devel Mar 5, 2025
1 check failed
@tonywu1999 tonywu1999 deleted the deril-dev-plotly-PTM branch July 11, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants