Adding Plotly feature to MSstatsPTM with Error Handling #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new Plotly library to MSstatsPTM to render Plotly plots back to MSstatsShiny app. The new parameter isPlotly to dataProcessPlotsPTM and groupComparisonPlotsPTM function handles this. If isPlotly is set to FALSE, it behaves normally (renders ggPlots).
In git diff, all the lines in the files appears to be changed. Devon and I identified this problem as issues with line endings. Below is a possible approach to fix it
There is this homebrew package dos2unix that converts file endings to what we need. Here is a test that I did
develcalledtest-1and applied thisdos2unixpackage onR/dataProcessPlotsPTM.Rhttps://github.com/Vitek-Lab/MSstatsPTM/compare/devel...test-1?expand=1 It shows all the lines have changed because we have converted the line endingstest-2which is checked out fromtest-1and then made a small line change to verify git recognizes only that line has changed and it works https://github.com/Vitek-Lab/MSstatsPTM/compare/test-1...test-2?expand=1dos2unixand then checkout into the feature branch to make changes