add capability to configure server timeouts #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pashidlos
reviewed
Mar 16, 2023
| onApplicationBootstrap() { | ||
| const server: Server = this.refHost.httpAdapter.getHttpServer(); | ||
| const { timeout, headersTimeout, keepAliveTimeout } = server; | ||
| server.timeout = parseInt(this.configService.get('SERVER_TIMEOUT', timeout.toString())); |
There was a problem hiding this comment.
could you check it's working when variable is not set?
might need default value for them of avoid assigning if it's undefined
There was a problem hiding this comment.
sure
I'm currently running this with an image i build myself.
line 17 is reading the defaults from node server and the second argument of this.configService.get assigns the default again, when the variable is not set
log from my server, after restart:
[Nest] 19 - 03/16/2023, 8:51:43 AM LOG [RouterExplorer] Mapped {/projects/:id, DELETE} route +1ms
[Nest] 19 - 03/16/2023, 8:51:44 AM LOG [AppService] timeout=120000
[Nest] 19 - 03/16/2023, 8:51:44 AM LOG [AppService] headersTimeout=60000
[Nest] 19 - 03/16/2023, 8:51:44 AM LOG [AppService] keepAliveTimeout=181000
[Nest] 19 - 03/16/2023, 8:51:44 AM LOG [NestApplication] Nest application successfully started +0ms
timeout and headersTimeout is the default from node https://nodejs.org/docs/latest-v12.x/api/http.html#http_server_headerstimeout
keepAliveTimeout is overwritten by environment variable SERVER_KEEP_ALIVE_TIMEOUT=181000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If vrt is running behind a reverse proxy sporadic 502 responses may occure due to incompatible timeouts.
This PR adds the capability to configure server timeouts.
More information at https://iximiuz.com/en/posts/reverse-proxy-http-keep-alive-and-502s/