Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing #212

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Typing #212

merged 1 commit into from
Aug 17, 2022

Conversation

Ardorax
Copy link
Contributor

@Ardorax Ardorax commented Aug 17, 2022

Fix:
Use Union with type None for all parameters to avoid typing problem. Done on all the object in aloscene

@Ardorax
Typing
6badaa5 
+ Add type None in union in prototype when None is the default value.

Signed-off-by: Valentin Dury <valentin03dury@gmail.com>
@Ardorax Ardorax added the documentation Improvements or additions to documentation label Aug 17, 2022
@Ardorax Ardorax self-assigned this Aug 17, 2022
@thibo73800 thibo73800 merged commit a4844cc into master Aug 17, 2022
@thibo73800 thibo73800 deleted the type branch August 17, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibo73800 thibo73800 thibo73800 approved these changes

Assignees

@Ardorax Ardorax

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ardorax @thibo73800