Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tracing assertion #182

Merged
merged 2 commits into from
May 24, 2022
Merged

remove tracing assertion #182

merged 2 commits into from
May 24, 2022

Conversation

Data-Iab
Copy link
Collaborator

@Data-Iab Data-Iab commented May 18, 2022

Quick fix:

  • Tracing assertion is removed from the BaseExporter.

@Data-Iab Data-Iab requested a review from thibo73800 May 18, 2022 11:31
@Data-Iab
Copy link
Collaborator Author

Tracing assertion is related to the disparity model, I suggest to move it to the DisparityExporter child class to avoid assertions for models that have tracing attribute.

@Data-Iab Data-Iab added aloscene aloscene quick-fix alonet and removed aloscene aloscene labels May 18, 2022
@thibo73800
Copy link
Contributor

thibo73800 commented May 19, 2022

@Data-Iab Is it not true that all model with the tracing property must be exported to onnx/tensorRT with tracing=True ?

@Data-Iab
Copy link
Collaborator Author

@thibo73800 well it depends on what tracing means, in AloDPTDepthSegmentation for example it does not refer to the same thing. For general purposes, we better handle assertions in child classes.

@thibo73800 thibo73800 merged commit 8d7d8f2 into master May 24, 2022
@thibo73800 thibo73800 deleted the dev branch May 24, 2022 08:56
@Data-Iab Data-Iab self-assigned this May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants