Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the Sudoku Project #1900

Merged
merged 8 commits into from
Jul 19, 2021
Merged

Adding the Sudoku Project #1900

merged 8 commits into from
Jul 19, 2021

Conversation

soma2000-lang
Copy link
Contributor

@soma2000-lang soma2000-lang commented Jul 17, 2021

Related Issue

  • The project is done using html ,javascript and css using the concept of backtracking

#1899

Describe the changes you've made

Added all the files of the Sudoku Solver

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.

Screenshots

WhatsApp Image 2021-07-18 at 02 19 06 (1)

@soma2000-lang
Copy link
Contributor Author

@Rizwan-S
Please look into this pull request

Copy link
Contributor

@Rizwan-S Rizwan-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the folder structure of the project. Put the html file in public folder and js, css files in relevant folders of assets folder. Also, please remove README file and also update this project's script.js file.

@soma2000-lang
Copy link
Contributor Author

@Rizwan-S
What changes shoud be done in script.js files

@Rizwan-S
Copy link
Contributor

You need to add your project in the array.

@soma2000-lang
Copy link
Contributor Author

@Rizwan-S made all thr changes ,Please look into it

Copy link
Contributor

@Rizwan-S Rizwan-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename 'Sudoku Solver.html' to 'Sudoku_Solver.html' & 'Sudoku Solver.jpeg' to 'Sudoku_Solver.jpeg'

@soma2000-lang
Copy link
Contributor Author

@Rizwan-S done

@Rizwan-S
Copy link
Contributor

You need to rename the js and css file also. My bad, I didn't notice it first :(

<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0/css/bootstrap.min.css" integrity="sha384-Gn5384xqQ1aoWXA+058RXPxPg6fy4IWvTNh0E263XmFcJlSAwiGgFAW/dAiS6JXm" crossorigin="anonymous">

<link rel="stylesheet" href="style.css">
<script defer src="script.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use '../assets/js/Sudoku_Solver.js' as script src.

<title>Document</title>
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0/css/bootstrap.min.css" integrity="sha384-Gn5384xqQ1aoWXA+058RXPxPg6fy4IWvTNh0E263XmFcJlSAwiGgFAW/dAiS6JXm" crossorigin="anonymous">

<link rel="stylesheet" href="style.css">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use '../assets/css/Sudoku_Solver.css' as href

@soma2000-lang
Copy link
Contributor Author

@Rizwan-S Sir made the modifications.

@Rizwan-S
Copy link
Contributor

Dude, this is wrong. Not everyone will place your files at that specific location. Please use what I mentioned.

@soma2000-lang
Copy link
Contributor Author

@Rizwan-S Sorry for my mistake
Check now

Copy link
Contributor

@Rizwan-S Rizwan-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work!!!

@Rizwan-S Rizwan-S merged commit 825fbc3 into Vishal-raj-1:main Jul 19, 2021
@github-actions
Copy link

Thank you @soma2000-lang for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)

@Rizwan-S Rizwan-S added LGMSOC21 🟥 Level4 This issue will be considered as level 4 issue for LGM-SOC 21. Points will be 45. labels Jul 19, 2021
@soma2000-lang
Copy link
Contributor Author

soma2000-lang commented Jul 19, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟥 Level4 This issue will be considered as level 4 issue for LGM-SOC 21. Points will be 45. LGMSOC21
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants