-
-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the Sudoku Project #1900
Conversation
@Rizwan-S |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the folder structure of the project. Put the html file in public folder and js, css files in relevant folders of assets folder. Also, please remove README file and also update this project's script.js file.
@Rizwan-S |
You need to add your project in the array. |
@Rizwan-S made all thr changes ,Please look into it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename 'Sudoku Solver.html' to 'Sudoku_Solver.html' & 'Sudoku Solver.jpeg' to 'Sudoku_Solver.jpeg'
@Rizwan-S done |
You need to rename the js and css file also. My bad, I didn't notice it first :( |
public/Sudoku_Solver.html
Outdated
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0/css/bootstrap.min.css" integrity="sha384-Gn5384xqQ1aoWXA+058RXPxPg6fy4IWvTNh0E263XmFcJlSAwiGgFAW/dAiS6JXm" crossorigin="anonymous"> | ||
|
||
<link rel="stylesheet" href="style.css"> | ||
<script defer src="script.js"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use '../assets/js/Sudoku_Solver.js' as script src.
public/Sudoku_Solver.html
Outdated
<title>Document</title> | ||
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0/css/bootstrap.min.css" integrity="sha384-Gn5384xqQ1aoWXA+058RXPxPg6fy4IWvTNh0E263XmFcJlSAwiGgFAW/dAiS6JXm" crossorigin="anonymous"> | ||
|
||
<link rel="stylesheet" href="style.css"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use '../assets/css/Sudoku_Solver.css' as href
@Rizwan-S Sir made the modifications. |
Dude, this is wrong. Not everyone will place your files at that specific location. Please use what I mentioned. |
@Rizwan-S Sorry for my mistake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Work!!!
Thank you @soma2000-lang for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :) |
Thank you sir
…On Mon, Jul 19, 2021, 19:12 github-actions[bot] ***@***.***> wrote:
Thank you @soma2000-lang <https://github.com/soma2000-lang> for taking
out your valuable time in order to contribute to our project. Looking
forward for more such amazing contributions :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1900 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANLS36N5JF6HXRKHJ5BL4JLTYQTVDANCNFSM5ARNC36Q>
.
|
Related Issue
#1899
Describe the changes you've made
Added all the files of the Sudoku Solver
Checklist:
Screenshots