Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Page Scroll Indicator #1877

Merged
merged 6 commits into from
Jul 14, 2021
Merged

Added Page Scroll Indicator #1877

merged 6 commits into from
Jul 14, 2021

Conversation

coding-geek21
Copy link
Contributor

Related Issue

  • Info about Issue or bug
  • Added Page Scroll Indicator

Closes: #1611

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • New and existing unit tests pass locally with my changes.

Screenshots

Put any screenshot(s) of the project here.
image

Copy link
Contributor

@Rizwan-S Rizwan-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the css and javascript codes in a separate css and js file. Also, please add the project in script.js file.

@coding-geek21 coding-geek21 requested a review from Rizwan-S July 10, 2021 11:42
@coding-geek21
Copy link
Contributor Author

coding-geek21 commented Jul 10, 2021

Done changes @Rizwan-S

Copy link
Contributor

@Rizwan-S Rizwan-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@Rizwan-S Rizwan-S merged commit 75160ba into Vishal-raj-1:main Jul 14, 2021
@Rizwan-S Rizwan-S added LGMSOC21 🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21. Points will be 30. labels Jul 14, 2021
@github-actions
Copy link

Thank you @coding-geek21 for taking out your valuable time in order to contribute to our project. Looking forward for more such amazing contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21. Points will be 30. LGMSOC21
Projects
None yet
Development

Successfully merging this pull request may close these issues.

addition of page scroll indicator
2 participants