-
Notifications
You must be signed in to change notification settings - Fork 330
Feat/pasted add row col plugin #3969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
fangsmile
wants to merge
11
commits into
develop
Choose a base branch
from
feat/pasted-add-row-col-plugin
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/paste-add-row-plugin
Feat pasted add row col plugin
fangsmile
commented
May 29, 2025
if (this.pluginOptions?.addRowCallback) { | ||
this.pluginOptions.addRowCallback(row, this.table); | ||
} else { | ||
this.table.addRecord([]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
逻辑不对 需要把未粘贴进来的数据 处理好新增进来 @xiaozisong
const isLastCol = col === maxColIndex; | ||
|
||
if ((!isLastRow && rowsNeeded <= 0) || (!isLastCol && colsNeeded <= 0)) { | ||
this.table.changeCellValues(col, row, pasteData, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里也是 新增列属性后 要对应的将数据update到对应行数据中 @xiaozisong
…asted_data-event-for-vtable
Rui-Sun
approved these changes
Jun 6, 2025
… columns are insufficient
…asted_data-event-for-vtable
…-event-for-vtable 3908 feature add pasted data event for vtable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough