-
Notifications
You must be signed in to change notification settings - Fork 330
feat: add a containerFit
option to ensure the table dimensions match its container
#3944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
huccct
wants to merge
4
commits into
VisActor:develop
Choose a base branch
from
huccct:feat/table-container-fit-mode
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9561beb
to
6a092c7
Compare
containerFit
option to ensure the table dimensions match its container
fangsmile
reviewed
May 30, 2025
/** | ||
* 表格外框始终撑满容器,内容区宽高不拉伸,剩余空白/超出滚动 | ||
*/ | ||
containerFit?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
官网docs中需要增加对象的配置教程和demo
@@ -1458,6 +1470,9 @@ export class Scenegraph { | |||
*/ | |||
dealWidthMode() { | |||
const table = this.table; | |||
if (table.containerFit) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里直接return 会有问题吧 widthMode就不起作用了?他们应该是不冲突的配置呀
可以本地再拉个develop分项目,综合对比测试下各种情况 跟之前的效果是否一致 看着改动比较大 @huccct |
6a092c7
to
d8482ed
Compare
containerFit
option to ensure the table dimensions match its containercontainerFit
option to ensure the table dimensions match its container
containerFit
option to ensure the table dimensions match its containercontainerFit
option to ensure the table dimensions match its container
done cc @fangsmile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#3337
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough