Skip to content

feat: add a containerFit option to ensure the table dimensions match its container #3944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

huccct
Copy link

@huccct huccct commented May 26, 2025

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Site / documentation update
  • Demo update
  • Workflow
  • Chore
  • Release
  • Other (about what?)

🔗 Related issue link

#3337

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@huccct huccct force-pushed the feat/table-container-fit-mode branch from 9561beb to 6a092c7 Compare May 28, 2025 22:10
@huccct huccct marked this pull request as ready for review May 28, 2025 22:12
@huccct huccct changed the title feat: 添加containerFit选项确保表格尺寸与容器匹配 feat: add a containerFit option to ensure the table dimensions match its container May 28, 2025
/**
* 表格外框始终撑满容器,内容区宽高不拉伸,剩余空白/超出滚动
*/
containerFit?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

官网docs中需要增加对象的配置教程和demo

@@ -1458,6 +1470,9 @@ export class Scenegraph {
*/
dealWidthMode() {
const table = this.table;
if (table.containerFit) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里直接return 会有问题吧 widthMode就不起作用了?他们应该是不冲突的配置呀

@fangsmile
Copy link
Contributor

可以本地再拉个develop分项目,综合对比测试下各种情况 跟之前的效果是否一致 看着改动比较大 @huccct

@huccct huccct force-pushed the feat/table-container-fit-mode branch from 6a092c7 to d8482ed Compare June 3, 2025 17:52
@huccct huccct changed the title feat: add a containerFit option to ensure the table dimensions match its container feat: add a containerFitoption to ensure the table dimensions match its container Jun 3, 2025
@huccct huccct changed the title feat: add a containerFitoption to ensure the table dimensions match its container feat: add a containerFit option to ensure the table dimensions match its container Jun 3, 2025
@github-actions github-actions bot added the docs label Jun 3, 2025
@huccct
Copy link
Author

huccct commented Jun 3, 2025

done cc @fangsmile

@huccct huccct requested a review from fangsmile June 9, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants