Skip to content

pe: null-terminate authenticode digest/thumbprint hex buffers #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plusvic merged 1 commit into from
Jul 6, 2026
+5 −0
Merged

pe: null-terminate authenticode digest/thumbprint hex buffers #2221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions libyara/modules/pe/pe.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1754,6 +1754,7 @@ static void pe_parse_exports(PE* pe)
char thumbprint_ascii[YR_SHA1_LEN * 2 + 1]; \
for (int j = 0; j < cert->sha1.len; ++j) \
sprintf(thumbprint_ascii + (j * 2), "%02x", cert->sha1.data[j]); \
thumbprint_ascii[cert->sha1.len * 2] = '\0'; \
\
yr_set_string( \
(char*) thumbprint_ascii, pe->object, fmt ".thumbprint", __VA_ARGS__); \
Expand Down Expand Up @@ -1820,6 +1821,7 @@ void _process_authenticode(
char* digest_ascii = yr_malloc(authenticode->digest.len * 2 + 1);
for (int j = 0; j < authenticode->digest.len; ++j)
sprintf(digest_ascii + (j * 2), "%02x", authenticode->digest.data[j]);
digest_ascii[authenticode->digest.len * 2] = '\0';

yr_set_string(
digest_ascii, pe->object, "signatures[%i].digest", *sig_count);
Expand All @@ -1832,6 +1834,7 @@ void _process_authenticode(
for (int j = 0; j < authenticode->file_digest.len; ++j)
sprintf(
digest_ascii + (j * 2), "%02x", authenticode->file_digest.data[j]);
digest_ascii[authenticode->file_digest.len * 2] = '\0';

yr_set_string(
digest_ascii, pe->object, "signatures[%i].file_digest", *sig_count);
Expand Down Expand Up @@ -1884,6 +1887,7 @@ void _process_authenticode(
char* digest_ascii = yr_malloc(signer->digest.len * 2 + 1);
for (int j = 0; j < signer->digest.len; ++j)
sprintf(digest_ascii + (j * 2), "%02x", signer->digest.data[j]);
digest_ascii[signer->digest.len * 2] = '\0';

yr_set_string(
digest_ascii,
Expand Down Expand Up @@ -1950,6 +1954,7 @@ void _process_authenticode(
char* digest_ascii = yr_malloc(counter->digest.len * 2 + 1);
for (int j = 0; j < counter->digest.len; ++j)
sprintf(digest_ascii + (j * 2), "%02x", counter->digest.data[j]);
digest_ascii[counter->digest.len * 2] = '\0';

yr_set_string(
digest_ascii,
Expand Down
Loading