-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #1708 #1710
Fix issue #1708 #1710
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, and thanks for catching it!
A test case for this issue would be great. Could you add a |
OK,I think I can construct one. |
Build a dotnet pe that triggers this issue: https://github.com/dangodangodango/BadDotnetPe
I build a dotnet pe that can triggers this issue: https://github.com/dangodangodango/BadDotnetPe , scanning it with dotnet rule will cause yara to return error 4 ( |
* Fix issue VirusTotal#1708 * Add test case for VirusTotal#1708 Build a dotnet pe that triggers this issue: https://github.com/dangodangodango/BadDotnetPe
Fix: wrong offset used when checking
Version
string of .net metadata andAddressOfEntryPoint
.